Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/whitelisting.js

Issue 29705719: Issue 6402 - Split filter hit / request logging out into own API (Closed)
Patch Set: Fixed typo and exposed pageId for logged requests Created Feb. 22, 2018, 3:55 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/requestBlocker.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/whitelisting.js
diff --git a/lib/whitelisting.js b/lib/whitelisting.js
index 4307511d17eb796d451f9ac4d1a7cccb3fce286e..bd03693e0e31df589862bb17fdaf2b45ad20237b 100644
--- a/lib/whitelisting.js
+++ b/lib/whitelisting.js
@@ -26,7 +26,7 @@ const {FilterStorage} = require("filterStorage");
const {stringifyURL, getDecodedHostname,
extractHostFromFrame, isThirdParty} = require("url");
const {port} = require("messaging");
-const devtools = require("devtools");
+const {logWhitelistedDocument} = require("devLogger");
const {verifySignature} = require("rsa");
let sitekeys = new ext.PageMap();
@@ -43,9 +43,9 @@ function match(page, url, typeMask, docDomain, sitekey)
urlString, typeMask, docDomain, thirdParty, sitekey
);
- if (filter && devtools)
+ if (filter)
{
- devtools.logWhitelistedDocument(
+ logWhitelistedDocument(
page, urlString, typeMask, docDomain, filter
);
}
« no previous file with comments | « lib/requestBlocker.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld