Unified Diff: lib/popupBlocker.js
Issue 29705719:
Issue 6402 - Split filter hit / request logging out into own API (Closed)
Patch Set: Addressed Sebastian's feedback
Created March 21, 2018, 3:14 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« lib/hitLogger.js ('K')
|
« lib/hitLogger.js ('k')
|
lib/requestBlocker.js » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: lib/popupBlocker.js |
| diff --git a/lib/popupBlocker.js b/lib/popupBlocker.js |
| index 91f0f23d834249cdea7477caea9dc90d85b5aadb..f2c4246fbc40e4c71cdb95e548bdc2a5969a3e6f 100644 |
| --- a/lib/popupBlocker.js |
| +++ b/lib/popupBlocker.js |
| @@ -23,7 +23,7 @@ const {defaultMatcher} = require("matcher"); |
| const {BlockingFilter, RegExpFilter} = require("filterClasses"); |
| const {stringifyURL, isThirdParty, extractHostFromFrame} = require("url"); |
| const {checkWhitelisted} = require("whitelisting"); |
| -const {logRequest} = require("devtools"); |
| +const {logRequest} = require("hitLogger"); |
| let loadingPopups = new Map(); |
| @@ -61,7 +61,7 @@ function checkPotentialPopup(tabId, popup) |
| browser.tabs.remove(tabId); |
| logRequest( |
| - popup.sourcePage, urlString, "POPUP", |
| + popup.sourcePage.id, urlString, "POPUP", |
| documentHost, thirdParty, null, |
| specificOnly, filter |
| ); |
« lib/hitLogger.js ('K')
|
« lib/hitLogger.js ('k')
|
lib/requestBlocker.js » ('j')
|
no next file with comments »
