Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/requestBlocker.js

Issue 29705719: Issue 6402 - Split filter hit / request logging out into own API (Closed)
Patch Set: Nightmarish rebase Created April 13, 2018, 3:20 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/requestBlocker.js
diff --git a/lib/requestBlocker.js b/lib/requestBlocker.js
index b677a666ce531a352d9d5437f405cfaaaa0feb26..74197cfb26ea377adcee41f7636f9b92265adbe7 100644
--- a/lib/requestBlocker.js
+++ b/lib/requestBlocker.js
@@ -28,7 +28,7 @@ const {Prefs} = require("./prefs");
const {checkWhitelisted, getKey} = require("./whitelisting");
const {stringifyURL, extractHostFromFrame, isThirdParty} = require("./url");
const {port} = require("./messaging");
-const devtools = require("./devtools");
+const {logRequest: hitLoggerLogRequest} = require("./hitLogger");
const extensionProtocol = new URL(browser.extension.getURL("")).protocol;
@@ -107,7 +107,7 @@ function logRequest(details, url, type, docDomain, thirdParty,
if (filter)
FilterNotifier.emit("filter.hitCount", filter, 0, 0, tabIds);
- devtools.logRequest(
+ hitLoggerLogRequest(
tabIds, url, type, docDomain,
thirdParty, sitekey,
specificOnly, filter

Powered by Google App Engine
This is Rietveld