Unified Diff: lib/popupBlocker.js
Issue 29705719:
Issue 6402 - Split filter hit / request logging out into own API (Closed)
Patch Set: Addressed Manish's feedback
Created May 9, 2018, 5:53 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« lib/hitLogger.js ('k')
|
lib/requestBlocker.js » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: lib/popupBlocker.js |
| diff --git a/lib/popupBlocker.js b/lib/popupBlocker.js |
| index ebccf1cf19fdb0443469db3e4be4d123a80e6fe1..193fc30930e93cd5afed5263bfd79c9705677fc0 100644 |
| --- a/lib/popupBlocker.js |
| +++ b/lib/popupBlocker.js |
| @@ -24,7 +24,7 @@ const {BlockingFilter, |
| RegExpFilter} = require("../adblockpluscore/lib/filterClasses"); |
| const {isThirdParty, extractHostFromFrame} = require("./url"); |
| const {checkWhitelisted} = require("./whitelisting"); |
| -const {logRequest} = require("./devtools"); |
| +const {logRequest} = require("./hitLogger"); |
| let loadingPopups = new Map(); |
| @@ -61,9 +61,9 @@ function checkPotentialPopup(tabId, popup) |
| browser.tabs.remove(tabId); |
| logRequest( |
| - [popup.sourcePage.id], url, "POPUP", |
| - documentHost, thirdParty, null, |
| - specificOnly, filter |
| + [popup.sourcePage.id], |
| + {url, type: "POPUP", docDomain: documentHost, thirdParty, specificOnly}, |
| + filter |
| ); |
| } |
« no previous file with comments
|
« lib/hitLogger.js ('k')
|
lib/requestBlocker.js » ('j')
|
no next file with comments »
