Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: lib/utils.js

Issue 29709602: Issue 6417 - Remove Utils.getString and the last (faulty) use of it (Closed)
Patch Set: Created Feb. 26, 2018, 3:02 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « lib/filterValidation.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 "use strict"; 18 "use strict";
19 19
20 let Utils = exports.Utils = { 20 let Utils = exports.Utils = {
21 systemPrincipal: null, 21 systemPrincipal: null,
22 getString(id)
23 {
24 return browser.i18n.getMessage("global_" + id);
25 },
26 runAsync(callback) 22 runAsync(callback)
27 { 23 {
28 if (document.readyState == "loading") 24 if (document.readyState == "loading")
29 { 25 {
30 // Make sure to not run asynchronous actions before all 26 // Make sure to not run asynchronous actions before all
31 // scripts loaded. This caused issues on Opera in the past. 27 // scripts loaded. This caused issues on Opera in the past.
32 let onDOMContentLoaded = () => 28 let onDOMContentLoaded = () =>
33 { 29 {
34 document.removeEventListener("DOMContentLoaded", onDOMContentLoaded); 30 document.removeEventListener("DOMContentLoaded", onDOMContentLoaded);
35 callback(); 31 callback();
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 { 66 {
71 let docLink = require("prefs").Prefs.documentation_link; 67 let docLink = require("prefs").Prefs.documentation_link;
72 return docLink.replace(/%LINK%/g, linkID) 68 return docLink.replace(/%LINK%/g, linkID)
73 .replace(/%LANG%/g, Utils.appLocale); 69 .replace(/%LANG%/g, Utils.appLocale);
74 }, 70 },
75 71
76 yield() 72 yield()
77 { 73 {
78 } 74 }
79 }; 75 };
OLDNEW
« no previous file with comments | « lib/filterValidation.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld