Issue 6424 - Use internal symbol in ext namespace

ext/common.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 /* global defineNamespace */
 
 "use strict";
 
 const internal = Symbol();

[Manish Jethani, 2018/02/28 15:23:27]

The symbol is defined in ext/common.js since it is common to the ext namespace.
It should remain inaccessible to code outside the ext namespace.

 
 {
   window.ext = {};
 
   defineNamespace(ext, internal);
 
   let EventTarget = ext[internal].EventTarget = function()
   {
     defineNamespace(this, internal);
 
     this[internal].listeners = new Set();
   };
   EventTarget.prototype = {
+    [internal]: {
+      dispatch(...args)
+      {
+        return [...this[internal].listeners].map(listener => listener(...args));
+      }
+    },
     addListener(listener)
     {
       this[internal].listeners.add(listener);
     },
     removeListener(listener)
     {
       this[internal].listeners.delete(listener);
     }
   };
 
-  ext[internal].dispatchEvent = (eventTarget, ...args) =>

[Manish Jethani, 2018/02/28 15:23:27]

EventTarget.prototype._dispatch is now ext[internal].dispatchEvent

-                                [...eventTarget[internal].listeners].map(
-                                  listener => listener(...args)
-                                );
-
 
   /* Message passing */
 
   ext.onMessage = new ext[internal].EventTarget();
 }