Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29712602: Noissue - Fix naming inconsistency in ContainsSelector (Closed)

Created:
March 1, 2018, 1:36 p.m. by Manish Jethani
Modified:
March 2, 2018, 11:05 a.m.
Reviewers:
kzar, hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Only fix naming inconsistency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M lib/content/elemHideEmulation.js View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6
Manish Jethani
March 1, 2018, 1:37 p.m. (2018-03-01 13:37:03 UTC) #1
Manish Jethani
Patch Set 1 The styles parameter in getSelectors is not used in PlainSelector and ContainsSelector. ...
March 1, 2018, 1:39 p.m. (2018-03-01 13:39:32 UTC) #2
hub
The idea was to maintain the function arity as we implement polymorphism. I'm ok with ...
March 1, 2018, 6:44 p.m. (2018-03-01 18:44:45 UTC) #3
Manish Jethani
Patch Set 2: Only fix naming inconsistency
March 1, 2018, 7:13 p.m. (2018-03-01 19:13:13 UTC) #4
hub
LGTM
March 1, 2018, 8:34 p.m. (2018-03-01 20:34:42 UTC) #5
kzar
March 2, 2018, 9:30 a.m. (2018-03-02 09:30:31 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld