libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java - Issue 29712652: Issue 6436 - Thread access crash

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java

Issue 29712652: Issue 6436 - Thread access crash (Closed)

Patch Set: Created March 1, 2018, 3:31 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java

diff --git a/libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java b/libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java

index afddda79172c8f3778c2155412c9b157552fb10d..44e6184c79ece049e6848ac1f57e96afeca6e92a 100644

--- a/libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java

+++ b/libadblockplus-android-webview/src/org/adblockplus/libadblockplus/android/webview/AdblockWebView.java

@@ -1154,9 +1154,12 @@ public class AdblockWebView extends WebView

if (url != null)

{

elemHideLatch = new CountDownLatch(1);

- elemHideThread = new ElemHideThread(elemHideLatch);

- elemHideThread.setFinishedRunnable(elemHideThreadFinishedRunnable);

- elemHideThread.start();

+ synchronized (elemHideThreadLockObject)

+ {

+ elemHideThread = new ElemHideThread(elemHideLatch);

+ elemHideThread.setFinishedRunnable(elemHideThreadFinishedRunnable);

+ elemHideThread.start();

+ }

}

else

{

« no previous file with comments | « no previous file | no next file » | no next file with comments »