Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(654)

Issue 29712655: Issue 6437 - Skip styles-only patterns on DOM mutations (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 3 weeks ago by Manish Jethani
Modified:
6 months ago
Reviewers:
hub, kzar
CC:
sergei
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Minor changes #

Patch Set 3 : Minor changes #

Patch Set 4 : Rebase #

Patch Set 5 : Fix ESLint errors #

Patch Set 6 : Merge patch #29716641 #

Total comments: 4

Patch Set 7 : Use typeof #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -54 lines) Patch
M lib/content/elemHideEmulation.js View 1 2 3 4 5 6 7 chunks +151 lines, -54 lines 0 comments Download

Messages

Total messages: 15
Manish Jethani
6 months, 3 weeks ago (2018-03-01 17:11:46 UTC) #1
Manish Jethani
Patch Set 1 See #6437 description. https://codereview.adblockplus.org/29712655/diff/29712656/lib/content/elemHideEmulation.js File lib/content/elemHideEmulation.js (left): https://codereview.adblockplus.org/29712655/diff/29712656/lib/content/elemHideEmulation.js#oldcode563 lib/content/elemHideEmulation.js:563: if (stylesheetOnlyChange && ...
6 months, 3 weeks ago (2018-03-01 17:18:12 UTC) #2
Manish Jethani
Patch Set 2: Minor changes
6 months, 3 weeks ago (2018-03-01 17:26:59 UTC) #3
Manish Jethani
Patch Set 3: Minor changes
6 months, 3 weeks ago (2018-03-01 17:50:29 UTC) #4
Manish Jethani
Patch Set 4: Rebase
6 months, 3 weeks ago (2018-03-02 11:27:55 UTC) #5
Manish Jethani
Patch Set 5: Fix ESLint errors
6 months, 2 weeks ago (2018-03-05 18:34:46 UTC) #6
Manish Jethani
Patch Set 6: Merge patch #29716641 https://codereview.adblockplus.org/29712655/diff/29717623/lib/content/elemHideEmulation.js File lib/content/elemHideEmulation.js (right): https://codereview.adblockplus.org/29712655/diff/29717623/lib/content/elemHideEmulation.js#newcode637 lib/content/elemHideEmulation.js:637: if (selectors.length > ...
6 months, 2 weeks ago (2018-03-08 21:08:16 UTC) #7
Manish Jethani
By the way I'm also trying to address the issue on the WebExt side, see ...
6 months, 2 weeks ago (2018-03-08 21:12:07 UTC) #8
Manish Jethani
https://codereview.adblockplus.org/29712655/diff/29717623/lib/content/elemHideEmulation.js File lib/content/elemHideEmulation.js (right): https://codereview.adblockplus.org/29712655/diff/29717623/lib/content/elemHideEmulation.js#newcode637 lib/content/elemHideEmulation.js:637: if (selectors.length > 0) On 2018/03/08 21:08:15, Manish Jethani ...
6 months, 2 weeks ago (2018-03-08 21:28:34 UTC) #9
Manish Jethani
On 2018/03/08 21:28:34, Manish Jethani wrote: > https://codereview.adblockplus.org/29712655/diff/29717623/lib/content/elemHideEmulation.js > File lib/content/elemHideEmulation.js (right): > > https://codereview.adblockplus.org/29712655/diff/29717623/lib/content/elemHideEmulation.js#newcode637 ...
6 months, 2 weeks ago (2018-03-08 22:44:49 UTC) #10
hub
https://codereview.adblockplus.org/29712655/diff/29717623/lib/content/elemHideEmulation.js File lib/content/elemHideEmulation.js (right): https://codereview.adblockplus.org/29712655/diff/29717623/lib/content/elemHideEmulation.js#newcode29 lib/content/elemHideEmulation.js:29: if (value === undefined) there is the argument of ...
6 months, 1 week ago (2018-03-14 13:04:03 UTC) #11
Manish Jethani
Patch Set 7: Use typeof https://codereview.adblockplus.org/29712655/diff/29717623/lib/content/elemHideEmulation.js File lib/content/elemHideEmulation.js (right): https://codereview.adblockplus.org/29712655/diff/29717623/lib/content/elemHideEmulation.js#newcode29 lib/content/elemHideEmulation.js:29: if (value === undefined) ...
6 months, 1 week ago (2018-03-14 14:54:53 UTC) #12
hub
LGTM
6 months, 1 week ago (2018-03-15 00:20:52 UTC) #13
Manish Jethani
On 2018/03/15 00:20:52, hub wrote: > LGTM Thanks! Dave, would you like to take a ...
6 months, 1 week ago (2018-03-15 05:32:56 UTC) #14
kzar
6 months ago (2018-03-19 20:07:01 UTC) #15
On 2018/03/15 05:32:56, Manish Jethani wrote:
> On 2018/03/15 00:20:52, hub wrote:
> > LGTM
> 
> Thanks!
> 
> Dave, would you like to take a look?

I think Hubert's approval is enough for this element hiding emulation code.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5