Issue 6432 - Hide remove button for additional filter lists

css/desktop-options.scss

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 97 matching lines @@
   display: block;
   padding: 0.6rem 0.8rem;
   background-color: transparent;
   font-size: 1rem;
   font-weight: 700;
   text-decoration: none;
   text-transform: uppercase;
   cursor: pointer;
 }
 
+button:disabled,
+button[aria-disabled="true"]
+{
+  cursor: default;
+}
+
 /* Ignore .icon to avoid overriding "specific" (primary, secondary) styles */
 button.primary:not(.icon),
 .button.primary:not(.icon)
 {
   border: 0px;
   color: #FFF;
   background-color: #077CA6;
 }
 
 button.primary:not([disabled]):not(.icon):hover,
@@ skipping 133 matching lines @@
   height: 1.2rem;
   padding: 0px;
 }
 
 button[role="checkbox"][disabled].icon:not(.toggle)::before,
 button[role="checkbox"][aria-disabled="true"].icon:not(.toggle)::before
 {
   border: 0rem;
   margin: 0.2rem;
   border-radius: 2px;
-  background-color: #ccc;
+  background-color: #b3b3b3;

[Thomas Greiner, 2018/03/08 19:28:19]

Detail: Isn't this redundant since we're setting `fill="#b3b3b3"` in the SVG
anyway?

[saroyanm, 2018/03/09 11:23:28]

It is not because we do not have dedicated disable state for the Accceptable Ads
button, this is something make sense to introduce after we update the specs.

This implementation is a hack in order to not introduce a new button, this is
something that needs to be change as part of Jeens change to the specs.

I'll change this color back to #ccc not to block this review with the color
discussion.

[Thomas Greiner, 2018/03/09 17:24:22]

Acknowledged.

 }
 
 button[role="checkbox"].icon:not(.toggle)::before
 {
   /* Using ?query as a workaround to chromium bug #643716 */
   background-image: url(icons/checkbox.svg?off#off);
 }
 
 button[role="checkbox"][aria-checked="true"].icon:not(.toggle)::before
 {
   background-image: url(icons/checkbox.svg?on#on);
 }
 
+button[role="checkbox"][aria-checked="true"].icon:disabled:not(.toggle)::before
+{
+  background-image: url(icons/checkbox.svg?on-disabled#on-disabled);
+}
+
 button[role="checkbox"].icon.toggle::before
 {
   background-image: url(icons/toggle.svg?on#on);
 }
 
 button[role="checkbox"][aria-checked="false"].icon.toggle::before
 {
   background-image: url(icons/toggle.svg?off#off);
 }
 
@@ skipping 771 matching lines @@
 }
 
 #dialog .table.list li button > span
 {
   flex: none;
   margin: 0rem 0.8rem;
   text-transform: none;
   font-weight: 400;
 }
 
+li.preconfigured [data-hide="preconfigured"]
+{
+  display: none !important;
+}
+
 /*
   Tooltips
 */
 
 .tooltip
 {
   position: relative;
   margin: 0rem;
   line-height: 1.5rem;
   text-decoration: none;
@@ skipping 474 matching lines @@
   font-size: 1rem;
   color: #077CA6;
   background-color: #E1F2FA;
 }
 
 #notification strong
 {
   flex: 1;
   text-align: center;
 }