skin/icons/checkbox.svg - Issue 29712664: Issue 6432 - Hide remove button for additional filter lists

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: skin/icons/checkbox.svg

Issue 29712664: Issue 6432 - Hide remove button for additional filter lists (Closed)

Left Patch Set: Keeping callback hell Created March 8, 2018, 6:02 p.m.

Right Patch Set: Reverted the colors back Created March 9, 2018, 11:25 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 <svg xmlns="http://www.w3.org/2000/svg">	1 <svg xmlns="http://www.w3.org/2000/svg">

2 <view id="on" viewBox="0 0 18 18"/>	2 <view id="on" viewBox="0 0 18 18"/>

3 <g fill="none" fill-rule="evenodd">	3 <g fill="none" fill-rule="evenodd">

4 <rect width="17" height="17" fill="#077CA6" stroke="#077CA6" rx="2" x=".5" y =".5" />	4 <rect width="17" height="17" fill="#077CA6" stroke="#077CA6" rx="2" x=".5" y =".5" />

5 <polyline stroke="#FFF" stroke-linecap="square" stroke-width="2" points="3.5 10.327 7.579 13.5 14.5 4.5" transform="rotate(6 9 9)"/>	5 <polyline stroke="#FFF" stroke-linecap="square" stroke-width="2" points="3.5 10.327 7.579 13.5 14.5 4.5" transform="rotate(6 9 9)"/>

6 </g>	6 </g>

7	7

8 <view id="off" viewBox="0 18 18 18"/>	8 <view id="off" viewBox="0 18 18 18"/>

9 <rect width="17" height="17" x=".5" y="18.5" fill="none" stroke="#000" rx="2"/ >	9 <rect width="17" height="17" x=".5" y="18.5" fill="none" stroke="#000" rx="2"/ >

10	10

11 <view id="on-disabled" viewBox="0 36 18 18"/>	11 <view id="on-disabled" viewBox="0 36 18 18"/>

12 <g fill="none" fill-rule="evenodd" transform="translate(0, 36)">	12 <g fill="none" fill-rule="evenodd" transform="translate(0, 36)">

13 <rect width="17" height="17" fill="#b3b3b3" stroke="#b3b3b3" rx="2" x=".5" y =".5" />	13 <rect width="17" height="17" fill="#ccc" stroke="#ccc" rx="2" x=".5" y=".5" />
Thomas Greiner 2018/03/08 19:28:19 According to Jeen's suggestion only the border sho According to Jeen's suggestion only the border should be `#B3B3B3` while the background should be `#CCC`. She also mentioned using `#B3B3B3` for the text but that particular change may be tricky so I'd say we can ignore that one for now and apply that later when the spec gets updated. saroyanm 2018/03/09 11:23:28 This is getting, complicated. changing the fill fo Show quoted text On 2018/03/08 19:28:19, Thomas Greiner wrote: > According to Jeen's suggestion only the border should be `#B3B3B3` while the > background should be `#CCC`. > > She also mentioned using `#B3B3B3` for the text but that particular change may > be tricky so I'd say we can ignore that one for now and apply that later when > the spec gets updated. This is getting, complicated. changing the fill for this item to "#ccc", distorts the button, I'll change this back to use #ccc for both states, to be consistent with old Acceptable Ads color and apply new changes as soon we have the final design update. Thomas Greiner 2018/03/09 17:24:22 Acknowledged. Show quoted text On 2018/03/09 11:23:28, saroyanm wrote: > On 2018/03/08 19:28:19, Thomas Greiner wrote: > > According to Jeen's suggestion only the border should be `#B3B3B3` while the > > background should be `#CCC`. > > > > She also mentioned using `#B3B3B3` for the text but that particular change may > > be tricky so I'd say we can ignore that one for now and apply that later when > > the spec gets updated. > > This is getting, complicated. changing the fill for this item to "#ccc", > distorts the button, I'll change this back to use #ccc for both states, to be > consistent with old Acceptable Ads color and apply new changes as soon we have > the final design update. Acknowledged.
14 <polyline stroke="#FFF" stroke-linecap="square" stroke-width="2" points="3.5 10.327 7.579 13.5 14.5 4.5" transform="rotate(6 9 9)"/>	14 <polyline stroke="#FFF" stroke-linecap="square" stroke-width="2" points="3.5 10.327 7.579 13.5 14.5 4.5" transform="rotate(6 9 9)"/>

15 </g>	15 </g>

16 </svg>	16 </svg>

LEFT	RIGHT