Issue 6432 - Hide remove button for additional filter lists

background.js

Index: background.js
===================================================================
--- a/background.js
+++ b/background.js
@@ -68,6 +68,7 @@
   }
 
   let params = {
+    additionalSubscriptions: false,

[Thomas Greiner, 2018/03/02 11:33:35]

Detail: Please also mention this new parameter in the README.

[Thomas Greiner, 2018/03/02 11:33:35]

Why not implement this the same way as "blockedURLs" and change the value to a
string that contains a list of URLs?

[saroyanm, 2018/03/02 13:50:29]

Done.

[saroyanm, 2018/03/02 13:50:29]

Done.

     blockedURLs: "",
     filterlistsReinitialized: false,
     addSubscription: false,
@@ -108,6 +109,7 @@
     shouldShowBlockElementMenu: true,
     show_devtools_panel: true,
     ui_warn_tracking: true,
+    additional_subscriptions: (params.additionalSubscriptions) ? ["https://easylist-downloads.adblockplus.org/easylistgermany+easylist.txt"] : [],

[kzar, 2018/03/02 09:57:01]

Nit: The paranthesis around params.additionalSubscriptions seem pointless.

Nit: This line is way too long, it passes linting since it contains a URL but
the purpose of that exception is to allow long URLs which would have to be split
up otherwise. How about having a few constants at the top of the file for these
URLS?

[Thomas Greiner, 2018/03/02 11:33:35]

Sounds like a personal preference which I usually leave up to the implementer.

[saroyanm, 2018/03/02 13:50:29]

Done.

[kzar, 2018/03/05 13:23:21]

Thanks

     subscriptions_exceptionsurl: "https://easylist-downloads.adblockplus.org/exceptionrules.txt",
     subscriptions_exceptionsurl_privacy: "https://easylist-downloads.adblockplus.org/exceptionrules-privacy-friendly.txt"
   };