Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/content/elemHideEmulation.js

Issue 29713583: Issue 6504 - Add useInlineStyles flag to ElemHideEmulation (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Change to ElemHideEmulation.useInlineStyles Created March 5, 2018, 1:17 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/content/elemHideEmulation.js
===================================================================
--- a/lib/content/elemHideEmulation.js
+++ b/lib/content/elemHideEmulation.js
@@ -411,16 +411,17 @@
}
function ElemHideEmulation(addSelectorsFunc, hideElemsFunc)
{
this.document = document;
this.addSelectorsFunc = addSelectorsFunc;
this.hideElemsFunc = hideElemsFunc;
this.observer = new MutationObserver(this.observe.bind(this));
+ this.useInlineStyles = true;
kzar 2018/03/19 21:18:54 This doesn't match `alwaysHideWithSelector` in the
Manish Jethani 2018/03/20 11:20:23 Done.
}
ElemHideEmulation.prototype = {
isSameOrigin(stylesheet)
{
try
{
return new URL(stylesheet.href).origin == this.document.location.origin;
@@ -568,17 +569,18 @@
}
generator = evaluate(pattern.selectors, 0, "",
this.document, cssStyles);
}
for (let selector of generator)
{
if (selector != null)
{
- if (isSelectorHidingOnlyPattern(pattern))
+ if (!this.useInlineStyles ||
+ isSelectorHidingOnlyPattern(pattern))
{
selectors.push(selector);
selectorFilters.push(pattern.text);
}
else
{
for (let element of this.document.querySelectorAll(selector))
{
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld