Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: include.preload.js

Issue 29714555: Issue 6441 - Avoid unnecessary shadow root (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Left Patch Set: Still switch to <content> Created March 8, 2018, 9:51 p.m.
Right Patch Set: Improve user agent check Created March 9, 2018, 12:32 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 346 matching lines...) Expand 10 before | Expand all | Expand 10 after
357 357
358 createShadowTree() 358 createShadowTree()
359 { 359 {
360 // Use Shadow DOM if available as to not mess with with web pages that 360 // Use Shadow DOM if available as to not mess with with web pages that
361 // rely on the order of their own <style> tags (#309). However, creating 361 // rely on the order of their own <style> tags (#309). However, creating
362 // a shadow root breaks running CSS transitions. So we have to create 362 // a shadow root breaks running CSS transitions. So we have to create
363 // the shadow root before transistions might start (#452). 363 // the shadow root before transistions might start (#452).
364 if (!("createShadowRoot" in document.documentElement)) 364 if (!("createShadowRoot" in document.documentElement))
365 return null; 365 return null;
366 366
367 // Use Shadow DOM only on Chrome version 65 and lower. Firefox's Shadow 367 // Both Firefox and Chrome 66+ support user style sheets, so we can avoid
368 // DOM v0 implementation is slightly different (e.g. no <shadow> element), 368 // creating an unnecessary shadow root on these platforms.
369 // while Chrome is deprecating Shadow DOM v0 in favor of Shadow DOM v1 and 369 let match = /\bChrome\/(\d+)/.exec(navigator.userAgent);
370 // user style sheets. 370 if (!match || match[1] >= 66)
Sebastian Noack 2018/03/08 23:22:59 This is irrelevant. We have feature detection abov
Manish Jethani 2018/03/08 23:57:51 You're right, I've updated the comment.
371 let {application, applicationVersion} = require("info");
Sebastian Noack 2018/03/08 23:22:59 Do we use the "info" module in any other content s
Manish Jethani 2018/03/08 23:57:51 We don't. OK, I'm checking the navigator.userAgent
372 if (application != "chrome" || parseInt(applicationVersion) > 65)
Sebastian Noack 2018/03/08 23:22:59 We don't care about the application, but about the
Manish Jethani 2018/03/08 23:57:51 Acknowledged.
373 return null; 371 return null;
374 372
375 // Using shadow DOM causes issues on some Google websites, 373 // Using shadow DOM causes issues on some Google websites,
376 // including Google Docs, Gmail and Blogger (#1770, #2602, #2687). 374 // including Google Docs, Gmail and Blogger (#1770, #2602, #2687).
377 if (/\.(?:google|blogger)\.com$/.test(document.domain)) 375 if (/\.(?:google|blogger)\.com$/.test(document.domain))
378 return null; 376 return null;
379 377
380 // Finally since some users have both AdBlock and Adblock Plus installed we 378 // Finally since some users have both AdBlock and Adblock Plus installed we
381 // have to consider how the two extensions interact. For example we want to 379 // have to consider how the two extensions interact. For example we want to
382 // avoid creating the shadowRoot twice. 380 // avoid creating the shadowRoot twice.
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
549 let element = event.target; 547 let element = event.target;
550 if (/^i?frame$/.test(element.localName)) 548 if (/^i?frame$/.test(element.localName))
551 checkCollapse(element); 549 checkCollapse(element);
552 }, true); 550 }, true);
553 } 551 }
554 552
555 window.checkCollapse = checkCollapse; 553 window.checkCollapse = checkCollapse;
556 window.elemhide = elemhide; 554 window.elemhide = elemhide;
557 window.typeMap = typeMap; 555 window.typeMap = typeMap;
558 window.getURLsFromElement = getURLsFromElement; 556 window.getURLsFromElement = getURLsFromElement;
LEFTRIGHT
« no previous file | no next file » | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld