Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: lib/coreUtils.js

Issue 29714613: Issue 6434 - Reimplement positionInParent with indexOf (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Left Patch Set: Switch to indexOf Created March 5, 2018, 9:01 p.m.
Right Patch Set: Move findIndex up Created March 20, 2018, 11:34 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « lib/content/elemHideEmulation.js ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 17 matching lines...) Expand all
28 return descriptor; 28 return descriptor;
29 } 29 }
30 exports.desc = desc; 30 exports.desc = desc;
31 31
32 function extend(cls, properties) 32 function extend(cls, properties)
33 { 33 {
34 return Object.create(cls.prototype, desc(properties)); 34 return Object.create(cls.prototype, desc(properties));
35 } 35 }
36 exports.extend = extend; 36 exports.extend = extend;
37 37
38 function indexOf(iterable, searchElement)
39 {
40 return findIndex(iterable, item => item === searchElement);
41 }
42 exports.indexOf = indexOf;
43
44 function findIndex(iterable, callback, thisArg) 38 function findIndex(iterable, callback, thisArg)
kzar 2018/03/19 20:53:22 Nit: Could you put findIndex first since indexOf c
Manish Jethani 2018/03/20 11:34:58 Done.
45 { 39 {
46 let index = 0; 40 let index = 0;
47 for (let item of iterable) 41 for (let item of iterable)
48 { 42 {
49 if (callback.call(thisArg, item)) 43 if (callback.call(thisArg, item))
50 return index; 44 return index;
51 45
52 index++; 46 index++;
53 } 47 }
54 48
55 return -1; 49 return -1;
56 } 50 }
57 exports.findIndex = findIndex; 51 exports.findIndex = findIndex;
52
53 function indexOf(iterable, searchElement)
54 {
55 return findIndex(iterable, item => item === searchElement);
56 }
57 exports.indexOf = indexOf;
LEFTRIGHT

Powered by Google App Engine
This is Rietveld