Unified Diff: lib/coreUtils.js
Issue 29714613:
Issue 6434 - Reimplement positionInParent with indexOf (Closed)
Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Switch to indexOf
Created March 5, 2018, 9:01 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« lib/content/elemHideEmulation.js ('k')
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: lib/coreUtils.js |
| =================================================================== |
| --- a/lib/coreUtils.js |
| +++ b/lib/coreUtils.js |
| @@ -29,8 +29,29 @@ |
| } |
| exports.desc = desc; |
| function extend(cls, properties) |
| { |
| return Object.create(cls.prototype, desc(properties)); |
| } |
| exports.extend = extend; |
| + |
| +function indexOf(iterable, searchElement) |
| +{ |
| + return findIndex(iterable, item => item === searchElement); |
| +} |
| +exports.indexOf = indexOf; |
| + |
| +function findIndex(iterable, callback, thisArg) |
|
kzar
2018/03/19 20:53:22
Nit: Could you put findIndex first since indexOf c
Manish Jethani
2018/03/20 11:34:58
Done.
|
| +{ |
| + let index = 0; |
| + for (let item of iterable) |
| + { |
| + if (callback.call(thisArg, item)) |
| + return index; |
| + |
| + index++; |
| + } |
| + |
| + return -1; |
| +} |
| +exports.findIndex = findIndex; |
« no previous file with comments
|
« lib/content/elemHideEmulation.js ('k')
|
no next file »
|
no next file with comments »
