Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29715577: Issue 6449 - Switch to Harmony modules (Closed)

Created:
March 6, 2018, 10:20 a.m. by Manish Jethani
Modified:
March 18, 2019, 5:14 a.m.
Reviewers:
CC:
Sebastian Noack, kzar
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Patch Set 1 #

Total comments: 5

Patch Set 2 : Add lib/.eslintrc.json #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -186 lines) Patch
M .eslintignore View 1 chunk +1 line, -0 lines 0 comments Download
A lib/.eslintrc.json View 1 1 chunk +5 lines, -0 lines 1 comment Download
M lib/csp.js View 1 chunk +4 lines, -6 lines 0 comments Download
M lib/cssInjection.js View 1 chunk +8 lines, -10 lines 0 comments Download
M lib/devtools.js View 3 chunks +14 lines, -20 lines 0 comments Download
M lib/filterComposer.js View 2 chunks +13 lines, -24 lines 0 comments Download
M lib/filterValidation.js View 3 chunks +4 lines, -7 lines 0 comments Download
M lib/firefoxDataCleanup.js View 1 chunk +6 lines, -8 lines 0 comments Download
M lib/icon.js View 2 chunks +3 lines, -6 lines 0 comments Download
M lib/io.js View 2 chunks +1 line, -4 lines 0 comments Download
M lib/messaging.js View 2 chunks +7 lines, -9 lines 0 comments Download
M lib/notificationHelper.js View 2 chunks +10 lines, -13 lines 0 comments Download
M lib/options.js View 2 chunks +5 lines, -8 lines 0 comments Download
M lib/popupBlocker.js View 1 chunk +5 lines, -7 lines 0 comments Download
M lib/prefs.js View 2 chunks +2 lines, -4 lines 0 comments Download
M lib/requestBlocker.js View 2 chunks +10 lines, -12 lines 0 comments Download
M lib/stats.js View 1 chunk +5 lines, -8 lines 0 comments Download
M lib/subscriptionInit.js View 3 chunks +3 lines, -5 lines 0 comments Download
M lib/tldjs.js View 1 chunk +1 line, -3 lines 0 comments Download
M lib/uninstall.js View 1 chunk +3 lines, -5 lines 0 comments Download
M lib/url.js View 4 chunks +6 lines, -9 lines 0 comments Download
M lib/utils.js View 1 chunk +1 line, -3 lines 0 comments Download
M lib/whitelisting.js View 3 chunks +11 lines, -15 lines 0 comments Download

Messages

Total messages: 3
Manish Jethani
March 6, 2018, 10:21 a.m. (2018-03-06 10:21:06 UTC) #1
Manish Jethani
Patch Set 1 https://codereview.adblockplus.org/29715577/diff/29715578/.eslintignore File .eslintignore (right): https://codereview.adblockplus.org/29715577/diff/29715578/.eslintignore#newcode1 .eslintignore:1: lib/compat.js Let's ignore lib/compat.js? It's not ...
March 6, 2018, 10:29 a.m. (2018-03-06 10:29:07 UTC) #2
Manish Jethani
March 6, 2018, 10:31 a.m. (2018-03-06 10:31:20 UTC) #3 
Patch Set 2: Add lib/.eslintrc.json

https://codereview.adblockplus.org/29715577/diff/29715601/lib/.eslintrc.json
File lib/.eslintrc.json (right):

https://codereview.adblockplus.org/29715577/diff/29715601/lib/.eslintrc.json#...
lib/.eslintrc.json:3: "sourceType": "module"
This tells ESLint to parse the files in this directory as "modules"

Powered by Google App Engine
This is Rietveld