package.json - Issue 29715740: Noissue - bundle in one operation to ensure no races

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: package.json

Issue 29715740: Noissue - bundle in one operation to ensure no races (Closed)

Patch Set: Created March 6, 2018, 3:24 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 {	1 {

2 "name": "adblockplusui",	2 "name": "adblockplusui",

3 "private": true,	3 "private": true,

4 "description": "Adblock Plus UI",	4 "description": "Adblock Plus UI",

5 "scripts": {	5 "scripts": {

6 "lint": "npm run lint:js",	6 "lint": "npm run lint:js",

7 "lint:js": "eslint ./.js ./lib/.js ./ext/*.js",	7 "lint:js": "eslint ./.js ./lib/.js ./ext/*.js",

8 "prepare": "python2 ensure_dependencies.py",	8 "prepare": "python2 ensure_dependencies.py",

9 "start": "http-server & npm run watch",	9 "start": "http-server & npm run watch",

10 "bundle": "npm run bundle:desktop-options",	10 "bundle": "npm run bundle:desktop-options",

11 "bundle:desktop-options": "eslint ./js/*/.js && echo '/* eslint-disable */ // BUNDLED FILE'>./desktop-options.js && browserify --node --no-bundle-external js/desktop-options.js >> ./desktop-options.js",	11 "bundle:desktop-options": "eslint ./js/*/.js && bash -c 'echo \"/* eslint- disable */$(browserify --node --no-bundle-external js/desktop-options.js)\">./de sktop-options.js'",
	Thomas Greiner 2018/03/07 13:48:11 Note: That's good for now but maybe we should star Note: That's good for now but maybe we should start going beyond bash soon, now that the build steps are becoming more complex and more difficult to read. a.giammarchi 2018/03/07 14:09:00 one possible improvement is to have a single bash. Show quoted text On 2018/03/07 13:48:11, Thomas Greiner wrote: > Note: That's good for now but maybe we should start going beyond bash soon, now > that the build steps are becoming more complex and more difficult to read. one possible improvement is to have a single bash.js and/or bash.css entry to use with that one liner and a `$SOURCE` and a `$DEST` variable so that a bundle:something.js would be `npm run bash.js ./js/something.js ./something.js` and it's easier/cleaner to add proper bundling instead of copy/pasting and manually replacing each file. At the end of the day, in a way or another, we need to update sources/targets while migrating, then we can just switch to more complex bundlers once we've fully migrated to the new structure. Thoughts? Thomas Greiner 2018/03/07 14:25:49 Sounds like a workable approach and it's also pret Show quoted text On 2018/03/07 14:09:00, a.giammarchi wrote: > On 2018/03/07 13:48:11, Thomas Greiner wrote: > > Note: That's good for now but maybe we should start going beyond bash soon, > now > > that the build steps are becoming more complex and more difficult to read. > > one possible improvement is to have a single bash.js and/or bash.css entry to > use with that one liner and a `$SOURCE` and a `$DEST` variable so that a > bundle:something.js would be `npm run bash.js ./js/something.js ./something.js` > and it's easier/cleaner to add proper bundling instead of copy/pasting and > manually replacing each file. > > At the end of the day, in a way or another, we need to update sources/targets > while migrating, then we can just switch to more complex bundlers once we've > fully migrated to the new structure. > > Thoughts? Sounds like a workable approach and it's also pretty similar to how we use gulp for building the Flattr extension (see https://github.com/flattr/flattr-extension/blob/master/package.json). I also agree with your assessment that we're not at the point yet where we should avoid more complex build logic until we've fully migrated all of the code. So for now forwarding npm commands to a simple script seems indeed ideal.
12 "watch": "npm run watch:desktop-options",	12 "watch": "npm run watch:desktop-options",

13 "watch:desktop-options": "watch 'npm run bundle:desktop-options' ./js",	13 "watch:desktop-options": "watch 'npm run bundle:desktop-options' ./js",

14 "postinstall": "npm run bundle"	14 "postinstall": "npm run bundle"

15 },	15 },

16 "devDependencies": {	16 "devDependencies": {

17 "browserify": "^16.1.0",	17 "browserify": "^16.1.0",

18 "eslint": "^4.16.0",	18 "eslint": "^4.16.0",

19 "eslint-config-eyeo": "^2.0.0",	19 "eslint-config-eyeo": "^2.0.0",

20 "http-server": "^0.11.1",	20 "http-server": "^0.11.1",

21 "watch": "^1.0.2"	21 "watch": "^1.0.2"

22 }	22 }

23 }	23 }

OLD	NEW

« README.md ('K') | « README.md ('k') | no next file » | no next file with comments »