Noissue - bundle in one operation to ensure no races

package.json

Index: package.json
===================================================================
--- a/package.json
+++ b/package.json
@@ -3,17 +3,17 @@
   "private": true,
   "description": "Adblock Plus UI",
   "scripts": {
     "lint": "npm run lint:js",
     "lint:js": "eslint ./*.js ./lib/*.js ./ext/*.js",
     "prepare": "python2 ensure_dependencies.py",
     "start": "http-server & npm run watch",
     "bundle": "npm run bundle:desktop-options",
-    "bundle:desktop-options": "eslint ./js/**/*.js && echo '/* eslint-disable */// BUNDLED FILE'>./desktop-options.js && browserify --node --no-bundle-external js/desktop-options.js >> ./desktop-options.js",
+    "bundle:desktop-options": "eslint ./js/**/*.js && bash -c 'echo \"/* eslint-disable */$(browserify --node --no-bundle-external js/desktop-options.js)\">./desktop-options.js'",

[Thomas Greiner, 2018/03/07 13:48:11]

Note: That's good for now but maybe we should start going beyond bash soon, now
that the build steps are becoming more complex and more difficult to read.

[a.giammarchi, 2018/03/07 14:09:00]

one possible improvement is to have a single bash.js and/or bash.css entry to
use with that one liner and a `$SOURCE` and a `$DEST` variable so that a
bundle:something.js would be `npm run bash.js ./js/something.js ./something.js`
and it's easier/cleaner to add proper bundling instead of copy/pasting and
manually replacing each file.

At the end of the day, in a way or another, we need to update sources/targets
while migrating, then we can just switch to more complex bundlers once we've
fully migrated to the new structure.

Thoughts?

[Thomas Greiner, 2018/03/07 14:25:49]

Sounds like a workable approach and it's also pretty similar to how we use gulp
for building the Flattr extension (see
https://github.com/flattr/flattr-extension/blob/master/package.json).

I also agree with your assessment that we're not at the point yet where we
should avoid more complex build logic until we've fully migrated all of the
code. So for now forwarding npm commands to a simple script seems indeed ideal.

     "watch": "npm run watch:desktop-options",
     "watch:desktop-options": "watch 'npm run bundle:desktop-options' ./js",
     "postinstall": "npm run bundle"
   },
   "devDependencies": {
     "browserify": "^16.1.0",
     "eslint": "^4.16.0",
     "eslint-config-eyeo": "^2.0.0",