Issue 6440 - Use long-lived connections to listen to extension events

firstRun.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 52 matching lines @@
       // Show warning if filterlists settings were reinitialized
       if (issues.filterlistsReinitialized)
       {
         E("filterlistsReinitializedWarning").removeAttribute("hidden");
         setLinks("filterlistsReinitializedWarning", openFilters);
       }
     });
 
     updateSocialLinks();
 
-    ext.onMessage.addListener((message) =>
+    let port = browser.runtime.connect({name: "ui"});

[saroyanm, 2018/03/07 17:49:44]

We probably need to update the Mock polyfill as well for runtime.connect ->
https://hg.adblockplus.org/adblockplusui/file/tip/ext/content.js#l64

[Thomas Greiner, 2018/03/07 19:19:39]

Done. Since the issue doesn't occur in the test environment I didn't check
whether it works on that too. Anyway, great that you pointed it out.

+
+    port.onMessage.addListener((message) =>
     {
       if (message.type == "subscriptions.respond")
       {
         updateSocialLinks();
       }
     });
-    browser.runtime.sendMessage({
+
+    port.postMessage({
       type: "subscriptions.listen",
       filter: ["added", "removed", "updated", "disabled"]
     });
   }
 
   function updateSocialLinks()
   {
     for (let network of ["twitter", "facebook", "gplus"])
     {
       let link = E("share-" + network);
@@ skipping 21 matching lines @@
     });
   }
 
   function openFilters()
   {
     browser.runtime.sendMessage({type: "app.open", what: "options"});
   }
 
   document.addEventListener("DOMContentLoaded", onDOMLoaded, false);
 }());