Issue 6451 - Generate $csp exception filters properly

devtools-panel.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 32 matching lines @@
 
   if (request.type == "POPUP")
   {
     options.push("popup");
 
     if (request.url == "about:blank")
       domainSpecific = true;
   }
 
   if (request.type == "CSP")
-    options.push("CSP");

[Thomas Greiner, 2018/03/07 14:34:44]

Detail: I know that filter options are case insensitive but all filters we
create use lower-case filter options so, for the sake of consistency, I'd say
let's push the string "csp" instead.

That's also the way it was proposed in the ticket.

[kzar, 2018/03/07 15:11:40]

Done.

+    options.push("csp");
 
   if (domainSpecific)
     options.push("domain=" + request.docDomain);
 
   if (options.length > 0)
     filter += "$" + options.join(",");
 
   return filter;
 }
 
@@ skipping 194 matching lines @@
         break;
     }
   });
 
   // Since Chrome 54 the themeName is accessible, for earlier versions we must
   // assume the default theme is being used.
   // https://bugs.chromium.org/p/chromium/issues/detail?id=608869
   let theme = browser.devtools.panels.themeName || "default";
   document.body.classList.add(theme);
 }, false);