Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/MainPreferences.java

Issue 29716681: Issue 6454 - IllegalStateException crash (Closed)
Left Patch Set: Created March 7, 2018, 8:33 p.m.
Right Patch Set: Adjusting engine check Created March 9, 2018, 11:42 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 protected void onStop() 77 protected void onStop()
78 { 78 {
79 super.onStop(); 79 super.onStop();
80 SharedPrefsUtils.unregisterOnSharedPreferenceChangeListener(this, listener); 80 SharedPrefsUtils.unregisterOnSharedPreferenceChangeListener(this, listener);
81 this.dismissDialog(); 81 this.dismissDialog();
82 } 82 }
83 83
84 @Override 84 @Override
85 protected void onDestroy() 85 protected void onDestroy()
86 { 86 {
87 EngineManager.getInstance().removeEngineCreatedCallback(this); 87 EngineManager.getInstance().removeOnEngineCreatedCallback(this);
88 super.onDestroy(); 88 super.onDestroy();
89 } 89 }
90 90
91 private void dismissDialog() 91 private void dismissDialog()
92 { 92 {
93 if (this.dialog != null) 93 if (this.dialog != null)
94 { 94 {
95 this.dialogTitleResId = 0; 95 this.dialogTitleResId = 0;
96 this.dialog.dismiss(); 96 this.dialog.dismiss();
97 this.dialog = null; 97 this.dialog = null;
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
308 else if (getString(R.string.key_application_activated).equals(key)) 308 else if (getString(R.string.key_application_activated).equals(key))
309 { 309 {
310 if (dialogTitleResId == R.string.setup_dialog_title) 310 if (dialogTitleResId == R.string.setup_dialog_title)
311 { 311 {
312 dismissDialog(); 312 dismissDialog();
313 } 313 }
314 } 314 }
315 } 315 }
316 }; 316 };
317 } 317 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld