adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/ConnectivityChanged.java - Issue 29716681: Issue 6454 - IllegalStateException crash

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/ConnectivityChanged.java

Issue 29716681: Issue 6454 - IllegalStateException crash (Closed)

Patch Set: Adjusting engine check Created March 9, 2018, 11:42 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/ConnectivityChanged.java

===================================================================

--- a/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/ConnectivityChanged.java

+++ b/adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/ConnectivityChanged.java

@@ -18,7 +18,7 @@

package org.adblockplus.sbrowser.contentblocker;

import org.adblockplus.sbrowser.contentblocker.engine.Engine;

-import org.adblockplus.sbrowser.contentblocker.engine.EngineService;

+import org.adblockplus.sbrowser.contentblocker.engine.EngineManager;

import android.content.BroadcastReceiver;

import android.content.Context;

@@ -26,7 +26,7 @@

import android.util.Log;

public class ConnectivityChanged extends BroadcastReceiver implements

- EngineService.OnEngineCreatedCallback

+ EngineManager.OnEngineCreatedCallback

{

private static final String TAG = ConnectivityChanged.class.getSimpleName();

@@ -38,14 +38,14 @@

if (intent != null && ACTION.equals(intent.getAction()))

{

Log.d(TAG, "Triggering connectivity changed event");

- EngineService.startService(context, this);

+ EngineManager.getInstance().retrieveEngine(context, this);

}

@Override

- public void onEngineCreated(Engine engine, boolean success)

+ public void onEngineCreated(Engine engine)

{

- if (success)

+ if (engine != null)

{

engine.connectivityChanged();

}