Issue 6371 - Update buildtools dep. to c830dfa08e2f, use AMO-signing API

sitescripts/extensions/bin/createNightlies.py

 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-present eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
@@ skipping 494 matching lines @@
                     'application/x-xpinstall'
                 )
             })
 
         request = self.generate_jwt_request(
             config.get('extensions', 'amo_key'),
             config.get('extensions', 'amo_secret'),
             upload_url,
             'PUT',
             data,
-            (('Content-Type', content_type),),

[Sebastian Noack, 2018/03/09 16:16:27]

Nit: I missed this one before. Again, comma after last argument.

Also the outer data structure should be a list, not at tuple. We only use tuples
for data that have structure (e.g. objects that can be unpacked, like the inner
structure here), and lists for data that have order (i.e. objects that have a
variable number of elements that are processed in a uniform way).

  self.generate_jwt_request(
      config.get('extensions', 'amo_key'),
      config.get('extensions', 'amo_secret'),
      upload_url,
      'PUT',
      data,
      [('Content-Type', content_type)]
  )

[tlucas, 2018/03/12 07:22:46]

Done.

[Vasily Kuznetsov, 2018/03/13 17:49:59]

I actually prefer the comma after the last argument in such constructions. It
allows adding and removing arguments without touching irrelevant lines. This is
especially important for something like dict literals, but seems also slightly
preferable in cases like this one.

+            [('Content-Type', content_type)]
         )
 
         try:
             urllib2.urlopen(request).close()
         except urllib2.HTTPError as e:
             try:
                 logging.error(e.read())
             finally:
                 e.close()
             raise
@@ skipping 355 matching lines @@
 
     file = open(nightlyConfigFile, 'wb')
     nightlyConfig.write(file)
 
 
 if __name__ == '__main__':
     parser = argparse.ArgumentParser()
     parser.add_argument('--download', action='store_true', default=False)
     args = parser.parse_args()
     main(args.download)