Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29716699: Issue 6453 - Update buildtools dep. to c830dfa08e2f, add custom ID and updateURL (Closed)

Created:
March 7, 2018, 10:11 p.m. by tlucas
Modified:
March 22, 2018, 8 a.m.
Reviewers:
Sebastian Noack, kzar
Base URL:
https://hg.adblockplus.org/adblockpluschrome/file/b6190ccd9928
Visibility:
Public.

Description

Issue 6453 - Update buildtools dep. to c830dfa08e2f, add custom ID and updateURL ** IMPORTANT ** This and https://codereview.adblockplus.org/29716693 have to land simultaneously.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M dependencies View 1 chunk +1 line, -1 line 0 comments Download
M ensure_dependencies.py View 2 chunks +2 lines, -2 lines 0 comments Download
M metadata.gecko View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10
tlucas
Patch Set 1
March 7, 2018, 10:14 p.m. (2018-03-07 22:14:24 UTC) #1
Sebastian Noack
LGTM
March 8, 2018, 2:41 a.m. (2018-03-08 02:41:42 UTC) #2
kzar
On 2018/03/08 02:41:42, Sebastian Noack wrote: > LGTM (Note since we are in feature freeze ...
March 19, 2018, 8:21 p.m. (2018-03-19 20:21:27 UTC) #3
Sebastian Noack
On 2018/03/19 20:21:27, kzar wrote: > (Note since we are in feature freeze take care ...
March 19, 2018, 9:22 p.m. (2018-03-19 21:22:22 UTC) #4
tlucas
On 2018/03/19 21:22:22, Sebastian Noack wrote: > On 2018/03/19 20:21:27, kzar wrote: > > (Note ...
March 20, 2018, 10:09 a.m. (2018-03-20 10:09:24 UTC) #5
kzar
On 2018/03/20 10:09:24, tlucas wrote: > On 2018/03/19 21:22:22, Sebastian Noack wrote: > > ...
March 20, 2018, 10:54 a.m. (2018-03-20 10:54:45 UTC) #6
tlucas
On 2018/03/20 10:54:45, kzar wrote: > On 2018/03/20 10:09:24, tlucas wrote: > > On 2018/03/19 ...
March 20, 2018, 11:32 a.m. (2018-03-20 11:32:24 UTC) #7
kzar
On 2018/03/20 11:32:24, tlucas wrote: > On 2018/03/20 10:54:45, kzar wrote: > > On 2018/03/20 ...
March 20, 2018, 1:55 p.m. (2018-03-20 13:55:13 UTC) #8
Sebastian Noack
On 2018/03/20 10:09:24, tlucas wrote: > Please note that i don't have push-permission for adblockpluschrome ...
March 20, 2018, 6:10 p.m. (2018-03-20 18:10:05 UTC) #9
tlucas
March 21, 2018, 9:32 a.m. (2018-03-21 09:32:15 UTC) #10
On 2018/03/20 18:10:05, Sebastian Noack wrote:
> On 2018/03/20 10:09:24, tlucas wrote:
> > Please note that i don't have push-permission for adblockpluschrome and that
> > some abpssembly / infrastructure stuff has to land simultaneously (
> > http://hub.eyeo.com/issues/8867 )
> > 
> > We might need to actually schedule this.
> 
> Any reason, why this change cannot already land in adblockpluschrome, before
the
> changes to abpssembly land? As far as I understand, abpssembly is just calling
> build.py, and you just verified that the output is the same after this change.

The change in metadata.gecko (i.e. the new name of the variables for "id")
cannot be read by the old abpssembly revision - unfortunately, abpssembly
fetches the app-id with the buildtools revision it depends on, but not the
revision coming with adblockpluschrome.

Powered by Google App Engine
This is Rietveld