Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(57)

Issue 29717611: [on hold] Issue 6455 - Use tabs.removeCSS on Chromium

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by Manish Jethani
Modified:
2 months, 1 week ago
Reviewers:
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

On hold until https://crbug.com/608854 is fixed.

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -15 lines) Patch
M lib/cssInjection.js View 2 chunks +54 lines, -15 lines 4 comments Download

Messages

Total messages: 6
Manish Jethani
1 year, 2 months ago (2018-03-08 18:00:52 UTC) #1
Manish Jethani
Patch Set 1 I've explained everything in the source comments. I think we can remove ...
1 year, 2 months ago (2018-03-08 18:06:16 UTC) #2
Manish Jethani
On 2018/03/08 18:06:16, Manish Jethani wrote: > I have written extensive tests so we can ...
1 year, 2 months ago (2018-03-08 18:09:33 UTC) #3
kzar
> I have written extensive tests so we can be certain of the exact behavior. ...
1 year, 2 months ago (2018-03-19 18:42:49 UTC) #4
Sebastian Noack
For reference, the discussion in https://codereview.adblockplus.org/29714638/, whether it's worth to remove the old stylesheet only ...
1 year, 2 months ago (2018-03-19 20:58:17 UTC) #5
Manish Jethani
1 year, 2 months ago (2018-03-21 16:23:35 UTC) #6
On 2018/03/19 20:58:17, Sebastian Noack wrote:
> For reference, the discussion in https://codereview.adblockplus.org/29714638/,
> whether it's worth to remove the old stylesheet only if unchanged, is also
> relevant for this change. I didn't reply on this review yet, since we should
> resolve that discussion first.

Let's put this patch on hold until we've figured out the optimizations in the
element hiding emulation implementation and how we're going to use style sheets
exactly, esp. how to keep the path-based CSS selectors updated in an efficient
way (#6437, #6504).

Also my comment here:

https://codereview.adblockplus.org/29714638/#msg19

I'll come back once those issues are resolved.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5