Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29720577: Issue 6288 - Publish stylelint-config-eyeo on npm (Closed)

Created:
March 12, 2018, 9:24 a.m. by ire
Modified:
April 13, 2018, 9:18 a.m.
Base URL:
https://hg.adblockplus.org/codingtools
Visibility:
Public.

Description

Issue 6288 - Publish stylelint-config-eyeo on npm

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Update version number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M stylelint-config-eyeo/package.json View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23
ire
March 12, 2018, 9:24 a.m. (2018-03-12 09:24:17 UTC) #1
ire
Tristan/Sebastian could you please take a look at this? According to this npm documentation, in ...
March 12, 2018, 9:30 a.m. (2018-03-12 09:30:27 UTC) #2
tlucas
On 2018/03/12 09:30:27, ire wrote: > Tristan/Sebastian could you please take a look at this? ...
March 12, 2018, 9:43 a.m. (2018-03-12 09:43:59 UTC) #3
ire
On 2018/03/12 09:43:59, tlucas wrote: > The "master"-branch not being synced should be fixed by ...
March 12, 2018, 9:48 a.m. (2018-03-12 09:48:03 UTC) #4
kzar1
When I published eslint-config-eyeo eyeo was a user and not an organisation. The ops team ...
March 12, 2018, 10:07 a.m. (2018-03-12 10:07:14 UTC) #5
tlucas
On 2018/03/12 10:07:14, kzar1 wrote: > When I published eslint-config-eyeo eyeo was a user and ...
March 12, 2018, 10:10 a.m. (2018-03-12 10:10:51 UTC) #6
ire
On 2018/03/12 10:10:51, tlucas wrote: > On 2018/03/12 10:07:14, kzar1 wrote: > > When I ...
March 12, 2018, 12:23 p.m. (2018-03-12 12:23:15 UTC) #7
ire
Update: This worked, but the name of the package was actually `@eyeo/stylelint-config-eyeo`, instead of just ...
March 12, 2018, 12:38 p.m. (2018-03-12 12:38:20 UTC) #8
ire
Another Update: I believe that the way to do this is to publish the package ...
March 14, 2018, 2:02 p.m. (2018-03-14 14:02:38 UTC) #9
kzar
March 14, 2018, 5:22 p.m. (2018-03-14 17:22:09 UTC) #10
ire
tluca kzar: Please see my previous message
April 10, 2018, 3:48 p.m. (2018-04-10 15:48:45 UTC) #11
tlucas
On 2018/04/10 15:48:45, ire wrote: > tluca kzar: Please see my previous message Hey - ...
April 10, 2018, 4:25 p.m. (2018-04-10 16:25:46 UTC) #12
ire
On 2018/04/10 16:25:46, tlucas wrote: > On 2018/04/10 15:48:45, ire wrote: > > tluca kzar: ...
April 10, 2018, 5:28 p.m. (2018-04-10 17:28:46 UTC) #13
ire
This has been done now, I didn't need to make this change to the repo, ...
April 12, 2018, 2:38 p.m. (2018-04-12 14:38:08 UTC) #14
ire
On 2018/04/12 14:38:08, ire wrote: > This has been done now, I didn't need to ...
April 12, 2018, 2:43 p.m. (2018-04-12 14:43:40 UTC) #15
Sebastian Noack
On 2018/04/10 16:25:46, tlucas wrote: > Hey - i'm sorry, but i think neither Dave ...
April 12, 2018, 2:52 p.m. (2018-04-12 14:52:13 UTC) #16
ire
On 2018/04/12 14:52:13, Sebastian Noack wrote: > On 2018/04/10 16:25:46, tlucas wrote: > > Hey ...
April 12, 2018, 2:56 p.m. (2018-04-12 14:56:35 UTC) #17
tlucas
On 2018/04/12 14:56:35, ire wrote: > On 2018/04/12 14:52:13, Sebastian Noack wrote: > > On ...
April 12, 2018, 3:12 p.m. (2018-04-12 15:12:41 UTC) #18
ire
On 2018/04/12 15:12:41, tlucas wrote: > On 2018/04/12 14:56:35, ire wrote: > > On 2018/04/12 ...
April 12, 2018, 3:15 p.m. (2018-04-12 15:15:56 UTC) #19
tlucas
On 2018/04/12 15:15:56, ire wrote: > On 2018/04/12 15:12:41, tlucas wrote: > > On 2018/04/12 ...
April 12, 2018, 3:38 p.m. (2018-04-12 15:38:50 UTC) #20
ire
On 2018/04/12 15:38:50, tlucas wrote: > On 2018/04/12 15:15:56, ire wrote: > > On 2018/04/12 ...
April 12, 2018, 3:44 p.m. (2018-04-12 15:44:11 UTC) #21
tlucas
> No worries, yes that is intentional. The change in Patch Set 3 is all ...
April 12, 2018, 3:46 p.m. (2018-04-12 15:46:30 UTC) #22
ire
April 13, 2018, 8:42 a.m. (2018-04-13 08:42:58 UTC) #23
On 2018/04/12 15:46:30, tlucas wrote:
> > No worries, yes that is intentional. The change in Patch Set 3 is all that
is
> > needed here.
> 
> Alright, sorry for the confusion. In that case it's LGTM

Thanks! I will email you the exported patch now.

Powered by Google App Engine
This is Rietveld