Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(606)

Issue 29720585: Noissue - Explicitly ignore asynchronous errors from tabs.insertCSS (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 1 week ago by Manish Jethani
Modified:
6 months, 1 week ago
Reviewers:
Sebastian Noack, kzar
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add comments #

Patch Set 3 : Update comment #

Total comments: 2

Patch Set 4 : Update comment #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M lib/cssInjection.js View 1 2 3 1 chunk +21 lines, -1 line 6 comments Download

Messages

Total messages: 14
Manish Jethani
6 months, 1 week ago (2018-03-12 10:46:00 UTC) #1
Manish Jethani
Patch Set 1 This is somewhat related to changeset 610f216e7442 On Canary it seems the ...
6 months, 1 week ago (2018-03-12 10:48:36 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29720585/diff/29720586/lib/cssInjection.js File lib/cssInjection.js (right): https://codereview.adblockplus.org/29720585/diff/29720586/lib/cssInjection.js#newcode80 lib/cssInjection.js:80: .catch(() => {}); To clarify, so the catch-block below ...
6 months, 1 week ago (2018-03-12 22:41:25 UTC) #3
Manish Jethani
https://codereview.adblockplus.org/29720585/diff/29720586/lib/cssInjection.js File lib/cssInjection.js (right): https://codereview.adblockplus.org/29720585/diff/29720586/lib/cssInjection.js#newcode80 lib/cssInjection.js:80: .catch(() => {}); On 2018/03/12 22:41:25, Sebastian Noack wrote: ...
6 months, 1 week ago (2018-03-13 06:09:48 UTC) #4
Sebastian Noack
https://codereview.adblockplus.org/29720585/diff/29720586/lib/cssInjection.js File lib/cssInjection.js (right): https://codereview.adblockplus.org/29720585/diff/29720586/lib/cssInjection.js#newcode80 lib/cssInjection.js:80: .catch(() => {}); On 2018/03/13 06:09:47, Manish Jethani wrote: ...
6 months, 1 week ago (2018-03-13 15:38:45 UTC) #5
Manish Jethani
https://codereview.adblockplus.org/29720585/diff/29720586/lib/cssInjection.js File lib/cssInjection.js (right): https://codereview.adblockplus.org/29720585/diff/29720586/lib/cssInjection.js#newcode80 lib/cssInjection.js:80: .catch(() => {}); On 2018/03/13 15:38:45, Sebastian Noack wrote: ...
6 months, 1 week ago (2018-03-13 17:14:20 UTC) #6
Manish Jethani
Patch Set 2: Add comments
6 months, 1 week ago (2018-03-13 17:14:36 UTC) #7
Manish Jethani
Patch Set 3: Update comment
6 months, 1 week ago (2018-03-13 17:43:32 UTC) #8
Sebastian Noack
https://codereview.adblockplus.org/29720585/diff/29721731/lib/cssInjection.js File lib/cssInjection.js (right): https://codereview.adblockplus.org/29720585/diff/29721731/lib/cssInjection.js#newcode98 lib/cssInjection.js:98: // errors. This is only the case on Firefox, ...
6 months, 1 week ago (2018-03-13 18:40:58 UTC) #9
Manish Jethani
Patch Set 4: Update comment https://codereview.adblockplus.org/29720585/diff/29721731/lib/cssInjection.js File lib/cssInjection.js (right): https://codereview.adblockplus.org/29720585/diff/29721731/lib/cssInjection.js#newcode98 lib/cssInjection.js:98: // errors. On 2018/03/13 ...
6 months, 1 week ago (2018-03-13 22:08:38 UTC) #10
Sebastian Noack
https://codereview.adblockplus.org/29720585/diff/29721797/lib/cssInjection.js File lib/cssInjection.js (right): https://codereview.adblockplus.org/29720585/diff/29721797/lib/cssInjection.js#newcode82 lib/cssInjection.js:82: promise.catch(() => {}); On 2018/03/13 22:08:38, Manish Jethani wrote: ...
6 months, 1 week ago (2018-03-13 23:02:21 UTC) #11
Manish Jethani
https://codereview.adblockplus.org/29720585/diff/29721797/lib/cssInjection.js File lib/cssInjection.js (right): https://codereview.adblockplus.org/29720585/diff/29721797/lib/cssInjection.js#newcode82 lib/cssInjection.js:82: promise.catch(() => {}); On 2018/03/13 23:02:21, Sebastian Noack wrote: ...
6 months, 1 week ago (2018-03-13 23:08:30 UTC) #12
Manish Jethani
https://codereview.adblockplus.org/29720585/diff/29721797/lib/cssInjection.js File lib/cssInjection.js (right): https://codereview.adblockplus.org/29720585/diff/29721797/lib/cssInjection.js#newcode104 lib/cssInjection.js:104: // the latter case, we cannot indicate failure to ...
6 months, 1 week ago (2018-03-13 23:10:30 UTC) #13
Sebastian Noack
6 months, 1 week ago (2018-03-13 23:16:00 UTC) #14
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5