Noissue - Explicitly ignore asynchronous errors from tabs.insertCSS

lib/cssInjection.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 58 matching lines @@
 function addStyleSheet(tabId, frameId, styleSheet)
 {
   try
   {
     browser.tabs.insertCSS(tabId, {
       code: styleSheet,
       cssOrigin: "user",
       frameId,
       matchAboutBlank: true,
       runAt: "document_start"
-    });
+    })
+    // Some errors on Chromium are asynchronous promise rejections
+    // (e.g. "Error: No frame with id 574 in tab 266"). We explicitly ignore
+    // these, because otherwise they show up in the log too often and make
+    // debugging difficult.
+    .catch(() => {});
   }
   catch (error)
   {
+    // If the error is about the "cssOrigin" option, this is an older version
+    // of Chromium (65 and below) or Firefox (52 and below) that does not
+    // support user style sheets.
     if (/\bcssOrigin\b/.test(error.message))
       userStyleSheetsSupported = false;
 
+    // Sometimes a frame gets removed from the document between the time the
+    // content script sends the "elemhide.getSelectors" message and the time
+    // the background page tries to inject a style sheet, which causes
+    // tabs.insertCSS to throw a frame-not-found error. We must handle any such
+    // errors.

[Sebastian Noack, 2018/03/13 18:40:58]

This is only the case on Firefox, while Chromium gives an asynchronous error in
this case, right? Mind making this explicit in the comment here?

Now, I also realize, that this means in case the frame doesn't exist anymore, on
Chrome we return true, but on Firefox we return false?

[Manish Jethani, 2018/03/13 22:08:38]

Done.

     return false;
   }
 
   return true;
 }
 
 function removeStyleSheet(tabId, frameId, styleSheet)
 {
   if (!styleSheetRemovalSupported)
     return;
@@ skipping 83 matching lines @@
     response.inlineEmulated = true;
 
   return response;
 });
 
 port.on("elemhide.injectSelectors", (message, sender) =>
 {
   updateFrameStyles(sender.page.id, sender.frame.id, message.selectors,
                     message.groupName);
 });