Issue 6396 - Error creating non debug build config

BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/arm.gni")
 import("//build/config/dcheck_always_on.gni")
 import("//build/config/host_byteorder.gni")
 import("//build/config/jumbo.gni")
 import("//build/config/mips.gni")
@@ skipping 146 matching lines @@
 v8_toolset_for_shell = "host"
 
 ###############################################################################
 # Configurations
 #
 config("internal_config") {
   visibility = [ ":*" ]  # Only targets in this file can depend on this.
 
   include_dirs = [ "." ]
 
-  if (is_component_build) {
+  if (is_component_build || v8_component_build) {
     defines = [ "BUILDING_V8_SHARED" ]
   }
 }
 
 config("internal_config_base") {
   visibility = [ ":*" ]  # Only targets in this file can depend on this.
 
   include_dirs = [ "." ]
 }
 
 # This config should be applied to code using the libplatform.
 config("libplatform_config") {
   include_dirs = [ "include" ]
   if (is_component_build) {
     defines = [ "USING_V8_PLATFORM_SHARED" ]
   }
 }
 
 # This config should be applied to code using the libbase.
 config("libbase_config") {
-  if (is_component_build) {
+  if (is_component_build || v8_component_build) {
     defines = [ "USING_V8_BASE_SHARED" ]
   }
   libs = []
   if (is_android && current_toolchain != host_toolchain) {
     libs += [ "log" ]
   }
 }
 
 # This config should be applied to code using the libsampler.
 config("libsampler_config") {
   include_dirs = [ "include" ]
 }
 
 # This config should only be applied to code using V8 and not any V8 code
 # itself.
 config("external_config") {
-  if (is_component_build) {
+  if (is_component_build || v8_component_build) {
     defines = [ "USING_V8_SHARED" ]
   }
   include_dirs = [
     "include",
     "$target_gen_dir/include",
   ]
 }
 
 # This config should only be applied to code that needs to be explicitly
 # aware of whether we are using startup data or not.
@@ skipping 544 matching lines @@
 
   script = "tools/run.py"
 
   sources = []
 
   outputs = [
     "$target_gen_dir/snapshot.cc",
   ]
 
   args = [
-    "./" + rebase_path(get_label_info(":mksnapshot($v8_snapshot_toolchain)",
-                                      "root_out_dir") + "/mksnapshot",
-                       root_build_dir),

[sergei, 2018/03/12 12:43:31]

Is it correct that `root_build_dir` is removed now? I have not looked into it
but it can be the reason of the crash, IMO. What is the result value when
rebase_path is called with the empty second argument?

[anton, 2018/03/12 12:51:22]

Previously it was relative path (relative to build folder which is in
`root_build_dir`). Now it's full absolute path. The reason is that for some
reason it can't link with `libv8..` in the same folder.  Probably we should
investigate more deeply why it did not work that way for Release build.

+    rebase_path(get_label_info(":mksnapshot($v8_snapshot_toolchain)",
+                               "root_out_dir") + "/mksnapshot"),
     "--startup_src",
     rebase_path("$target_gen_dir/snapshot.cc", root_build_dir),
   ]
 
   if (v8_random_seed != "0") {
     args += [
       "--random-seed",
       v8_random_seed,
     ]
   }
@@ skipping 44 matching lines @@
     "is_component_build=$is_component_build",
     "is_debug=$is_debug",
     "is_gcov_coverage=$is_gcov_coverage",
     "is_msan=$is_msan",
     "is_tsan=$is_tsan",
     "is_ubsan_vptr=$is_ubsan_vptr",
     "target_cpu=\"$target_cpu\"",
     "v8_enable_i18n_support=$v8_enable_i18n_support",
     "v8_target_cpu=\"$v8_target_cpu\"",
     "v8_use_snapshot=$v8_use_snapshot",
+    "v8_component_build=$v8_component_build"
   ]
 }
 
 ###############################################################################
 # Source Sets (aka static libraries)
 #
 
 source_set("v8_maybe_snapshot") {
   if (v8_use_snapshot && v8_use_external_startup_data) {
     public_deps = [
@@ skipping 1539 matching lines @@
     ]
   }
 
   if (v8_postmortem_support) {
     sources += [ "$target_gen_dir/debug-support.cc" ]
     deps += [ ":postmortem-metadata" ]
   }
 }
 
 v8_component("v8_libbase") {
+  force_shared_library = true
   sources = [
     "src/base/adapters.h",
     "src/base/atomic-utils.h",
     "src/base/atomicops.h",
     "src/base/atomicops_internals_atomicword_compat.h",
     "src/base/atomicops_internals_portable.h",
     "src/base/atomicops_internals_std.h",
     "src/base/base-export.h",
     "src/base/bits.cc",
     "src/base/bits.h",
@@ skipping 47 matching lines @@
     "src/base/utils/random-number-generator.cc",
     "src/base/utils/random-number-generator.h",
   ]
 
   configs = [ ":internal_config_base" ]
 
   public_configs = [ ":libbase_config" ]
 
   defines = []
 
-  if (is_component_build) {
+  if (is_component_build || v8_component_build) {
     defines = [ "BUILDING_V8_BASE_SHARED" ]
   }
 
   if (is_posix) {
     sources += [
       "src/base/platform/platform-posix-time.cc",
       "src/base/platform/platform-posix-time.h",
       "src/base/platform/platform-posix.cc",
       "src/base/platform/platform-posix.h",
     ]
@@ skipping 149 matching lines @@
 if (current_toolchain == v8_snapshot_toolchain) {
   v8_executable("mksnapshot") {
     visibility = [ ":*" ]  # Only targets in this file can depend on this.
 
     sources = [
       "src/snapshot/mksnapshot.cc",
     ]
 
     configs = [ ":internal_config" ]
 
+    if (v8_component_build) {
+      configs += [
+        "//build/config/gcc:rpath_for_built_shared_libraries",
+        #"//build/config/gcc:executable_ldconfig"

[sergei, 2018/03/12 12:43:31]

The commented line.

[anton, 2018/03/12 12:51:22]

Right, it's because the task is not finished yet.
I've left it to use it if required.

+        ]
+    }
+
     deps = [
       ":v8_base",
       ":v8_builtins_setup",
       ":v8_libbase",
       ":v8_libplatform",
       ":v8_nosnapshot",
       "//build/config:exe_and_shlib_deps",
       "//build/win:default_exe_manifest",
     ]
   }
@@ skipping 66 matching lines @@
     ":v8_simple_wasm_function_sigs_section_fuzzer",
     ":v8_simple_wasm_fuzzer",
     ":v8_simple_wasm_globals_section_fuzzer",
     ":v8_simple_wasm_imports_section_fuzzer",
     ":v8_simple_wasm_memory_section_fuzzer",
     ":v8_simple_wasm_names_section_fuzzer",
     ":v8_simple_wasm_types_section_fuzzer",
   ]
 }
 
-if (is_component_build) {
+# we need to have v8 shared libs as we have to link libadblockplus-jni.so with it
+if (true) {
   v8_component("v8") {
+    force_shared_library = true
     sources = [
       "src/v8dll-main.cc",
     ]
 
     public_deps = [
       ":v8_base",
       ":v8_maybe_snapshot",
     ]
 
     configs = [ ":internal_config" ]
@@ skipping 513 matching lines @@
   ]
 
   configs = [
     ":external_config",
     ":internal_config_base",
   ]
 }
 
 v8_fuzzer("wasm_compile_fuzzer") {
 }