Issue 6396 - Error creating non debug build config

gni/v8.gni

 # Copyright 2016 the V8 project authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/jumbo.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//build/config/v8_target_cpu.gni")
 import("//build/split_static_library.gni")
 
 declare_args() {
@@ skipping 27 matching lines @@
   # Use external files for startup data blobs:
   # the JS builtins sources and the start snapshot.
   v8_use_external_startup_data = ""
 
   # Enable ECMAScript Internationalization API. Enabling this feature will
   # add a dependency on the ICU library.
   v8_enable_i18n_support = true
 
   # Use static libraries instead of source_sets.
   v8_static_library = false
+
+  # we need to have libv8.cr.so and some other shared libraries to link libadblockplus-android.so
+  v8_component_build = false

[anton, 2018/03/12 11:23:19]

now we should add "v8_component_build=true":

gn gen --args='target_os="android" proprietary_codecs=true
is_official_build=true is_debug=false ffmpeg_branding="Chrome"
v8_component_build=true' out/ReleaseV8Shared

 }
 
 if (v8_use_external_startup_data == "") {
   # If not specified as a gn arg, use external startup data by default if
   # a snapshot is used and if we're not on ios.
   v8_use_external_startup_data = v8_use_snapshot && !is_ios
 }
 
 if (v8_enable_backtrace == "") {
   v8_enable_backtrace = is_debug && !v8_optimized_debug
@@ skipping 102 matching lines @@
             [ "//build/config/sanitizers:default_sanitizer_flags_but_coverage" ]
       } else {
         configs -= [ v8_path_prefix + ":v8_gcov_coverage_cflags" ]
       }
     }
     deps += [ v8_path_prefix + ":v8_dump_build_config" ]
   }
 }
 
 template("v8_component") {
-  component(target_name) {
-    forward_variables_from(invoker, "*", [ "configs" ])
-    configs += invoker.configs
-    configs -= v8_remove_configs
-    configs += v8_add_configs
+
+  if (defined(invoker.force_shared_library) && invoker.force_shared_library) {
+    shared_library(target_name) {
+      output_extension = "cr.so" # override default .so with .cr.so

[sergei, 2018/03/12 12:43:32]

it would be better to put the reason it's overridden.

[anton, 2018/03/12 12:51:22]

yes, i agree the comment could be better.
Actually it's explained here:
https://gitlab.com/eyeo/adblockplus/chromium/blob/dev-64.0.3249.2/build/toolc...
Since it works inly for is_component_build by default removing
`is_component_build=true` hurts - all the libs are having ".so" and this brings
additional issues.

TBD

[jens, 2018/03/13 13:17:48]

You could just add a link to the ticket which explains why it needs to be done.

+      forward_variables_from(invoker, "*", [ "configs" ])
+      configs += invoker.configs
+      configs -= v8_remove_configs
+      configs += v8_add_configs
+
+      if (is_android) {
+        configs -= [ "//build/config/android:hide_all_but_jni_onload" ]
+      }
+
+      if (!defined(deps)) {
+        deps = []
+      }
+
+      deps += [ "//build/config:exe_and_shlib_deps" ]
+    }
+  } else {
+    component(target_name) {
+      forward_variables_from(invoker, "*", [ "configs" ])
+      configs += invoker.configs
+      configs -= v8_remove_configs
+      configs += v8_add_configs
+    }
   }
+
 }