Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: static/css/index.css

Issue 29720653: Fixes #30 - Adjustments to hero unit section of index page (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Patch Set: Addressed #6 & #7 Created March 14, 2018, 12:38 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /****************************************************************************** 1 /******************************************************************************
2 * Temparary styles 2 * Temparary styles
3 *****************************************************************************/ 3 *****************************************************************************/
4 4
5 .avoid-wrap {display: inline-block;} 5 .avoid-wrap {display: inline-block;}
6 .small {font-size: smaller;} 6 .small {font-size: smaller;}
7 .maxthon-only {display: none;} 7 .maxthon-only {display: none;}
8 .maxthon .maxthon-only {display: block;} 8 .maxthon .maxthon-only {display: block;}
9 9
10 /****************************************************************************** 10 /******************************************************************************
11 * #hero-download 11 * #hero-download
12 *****************************************************************************/ 12 *****************************************************************************/
13 13
14 #hero-download 14 #hero-download
15 { 15 {
16 padding: 3em 1em; 16 padding: 3em 1em;
17 } 17 }
18 18
19 @media (min-width: 576px) and (max-width: 1023px) 19 @media (min-width: 576px) and (max-width: 1023px)
20 { 20 {
21 /* add spacing left/right on tablets */ 21 /* add spacing left/right on tablets */
22 #hero-download 22 #hero-download
23 { 23 {
24 padding-left: 3em; 24 padding-left: 3em;
25 padding-right: 3em; 25 padding-right: 3em;
26 } 26 }
27 } 27 }
28 28
29 @media(min-width: 1024px) 29 @media (max-width: 575px)
30 { 30 {
31 #hero-download 31 /* disable avoid-wrap inside h1 on mobile */
32 #hero-download h1 .avoid-wrap
32 { 33 {
33 padding-top: 6em; 34 display: inline;
34 /* 3em bottom looks like 6em because of thumbnail contents */
35 padding-bottom: 3em;
36 } 35 }
37 } 36 }
38 37
39 @media (max-width: 1023px) 38 @media (max-width: 1023px)
40 { 39 {
41 /* force hero unit columns to break on large tablets */ 40 /* force hero unit columns to break on large tablets */
42 #hero-download .column 41 #hero-download .column
43 { 42 {
44 width: 100%; 43 width: 100%;
45 } 44 }
46 } 45 }
47 46
47 @media (min-width: 1024px)
48 {
49 #hero-download
50 {
51 padding-top: 6em;
52 /* 3em bottom looks like 6em because of thumbnail contents */
53 padding-bottom: 4em;
54 }
55 }
56
48 #hero-download h1 57 #hero-download h1
49 { 58 {
50 /* Spacing is provided by the hero-download section */ 59 /* Spacing is provided by the hero-download section */
51 margin-top: 0; 60 margin-top: 0;
52 /* Reduced line-height to match design without hurting accessibility */
53 line-height: 1.25;
54 }
55
56 @media (max-width: 575px)
57 {
58 /* disable avoid-wrap inside h1 on mobile */
59 #hero-download h1 .avoid-wrap
60 {
61 display: inline;
62 }
63 } 61 }
64 62
65 @media (min-width: 576px) 63 @media (min-width: 576px)
66 { 64 {
67 /* make h1 larger sooner than usual */ 65 /* make h1 larger sooner than usual */
68 #hero-download h1 66 #hero-download h1
69 { 67 {
70 font-size: 2.4em 68 font-size: 2.4em;
71 } 69 }
72 70
73 /* force break without <br> on large screens */ 71 /* force break without <br> on large screens */
74 #hero-download h1 .avoid-wrap:first-of-type 72 #hero-download h1 .avoid-wrap:first-of-type
75 { 73 {
76 display: block; 74 display: block;
77 } 75 }
78 } 76 }
79 77
80 #hero-download-tos 78 #hero-download-tos
(...skipping 16 matching lines...) Expand all
97 { 95 {
98 #hero-download-button 96 #hero-download-button
99 { 97 {
100 /* force auto-width >= small tablets */ 98 /* force auto-width >= small tablets */
101 width: auto; 99 width: auto;
102 } 100 }
103 } 101 }
104 102
105 #hero-download-video 103 #hero-download-video
106 { 104 {
107 /* add 1em space above on phones & tablets */ 105 /* add space above on phones & tablets */
108 margin-top: 1em; 106 margin-top: 2em;
juliandoucette 2018/03/14 12:46:31 NIT: Added a little more space here (personal pref
109 /* prevent default full-width on small tablets */ 107 /* prevent default full-width on small tablets */
110 max-width: 550px; 108 max-width: 550px;
111 } 109 }
112 110
113 @media(min-width: 1024px) 111 @media(min-width: 1024px)
114 { 112 {
115 #hero-download-video 113 #hero-download-video
116 { 114 {
117 /* keep aligned-top despite padding below */ 115 /* keep aligned-top despite padding below */
118 margin-top: -1em; 116 margin-top: -1em;
(...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after
345 padding: 0px 30px; 343 padding: 0px 30px;
346 } 344 }
347 345
348 @media(max-width: 767px) 346 @media(max-width: 767px)
349 { 347 {
350 #footnote 348 #footnote
351 { 349 {
352 padding: 0px 20px; 350 padding: 0px 20px;
353 } 351 }
354 } 352 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld