Fixes #30 - Adjustments to hero unit section of index page

static/css/index.css

 /******************************************************************************
  * Temparary styles
  *****************************************************************************/
 
 .avoid-wrap {display: inline-block;}
 .small {font-size: smaller;}
 .maxthon-only {display: none;}
 .maxthon .maxthon-only {display: block;}
 
 /******************************************************************************
  * #hero-download
  *****************************************************************************/
 
 #hero-download
 {
-  padding: 3em 1em 3em 1em;

[ire, 2018/03/13 09:18:02]

NIT: Use shorthand `3em 1em` instead

[ire, 2018/03/13 09:18:02]

Shouldn't this just be 3em al around?

Spec: "Below 1024px (Below Desktop breakpoint) Ensure exactly 3rem all around
section"

[juliandoucette, 2018/03/13 14:23:08]

Done.

[juliandoucette, 2018/03/13 14:23:08]

No. I 3em on tablet until 1em on mobile. Sorry for confusion.

-}
-
-#hero-download h1 .avoid-wrap

[ire, 2018/03/13 09:18:03]

Is there a reason you didn't use `word-wrap`/`word-break` to stop the word
breaking?

[juliandoucette, 2018/03/13 14:23:09]

I think so? My intent was to prevent breaking between specific words. AFAICT
these two properties/values do not do exactly that. At least, `word-break:
keep-all;` doesn't seem to do it.

[ire, 2018/03/14 07:39:15]

Acknowledged.

-{
-  display: inline;
-}
-
-@media (min-width: 576px)
-{
+  padding: 3em 1em;
+}
+
+@media (min-width: 576px) and (max-width: 1023px)
+{
+  /* add spacing left/right on tablets */
   #hero-download
   {
     padding-left: 3em;
     padding-right: 3em;
   }
-
-  #hero-download h1
-  {
-    font-size: 2.4em
-  }
-
+}
+
+@media (max-width: 575px)
+{
+  /* disable avoid-wrap inside h1 on mobile */
   #hero-download h1 .avoid-wrap
   {
-    display: inline-block;
-  }
-
+    display: inline;
+  }
+}
+
+@media (max-width: 1023px)
+{
+  /* force hero unit columns to break on large tablets */
+  #hero-download .column
+  {
+    width: 100%;
+  }
+}
+
+@media (min-width: 1024px)
+{
+  #hero-download
+  {
+    padding-top: 6em;
+    padding-bottom: 6em;
+  }
+}
+
+#hero-download h1
+{
+  /* Spacing is provided by the hero-download section */
+  margin-top: 0;
+}
+
+@media (min-width: 576px)
+{
+  /* force break without <br> on large screens */
   #hero-download h1 .avoid-wrap:first-of-type
   {
     display: block;
   }
 }
 
-@media(min-width: 1024px)
-{
-  #hero-download
-  {
-    padding: 6em 1em 5em 1em;

[ire, 2018/03/13 09:18:02]

NIT: Shorthand `6em 1em 5em`

[ire, 2018/03/13 09:18:03]

Shouldn't this be `6em 1em`?

Spec: "Ensure exactly 6rem above and below section"

[juliandoucette, 2018/03/13 14:23:08]

Done.

[juliandoucette, 2018/03/13 14:23:08]

Yes and no. The ~space at the bottom of the image makes it *look* like more than
6em if 6em is applied. Therefore, we decided to go with 5em on bottom to achieve
the 6em *effect*/look.

I'm sorry. I should have addded a comment about this.

-  }
-}
-
-@media (max-width: 1023.98px)
-{
-  #hero-download .column
-  {
-    width: 100%;
-  }
-}
-
-#hero-download h1
-{
-  margin-top: 0;
-  line-height: 1.1;
-}
-
 #hero-download-tos
 {
-  display: block;
   margin-bottom: 0.5em;
 }
 
 #hero-download-button
 {
-  display: block;
+  display: inline-block;
+  min-width: 250px;
+  /* stretch full-width <= small tablets */
+  width: 100%;
+  /* 0.2em taller than normal buttons */
   padding-top: 0.8em;
   padding-bottom: 0.8em;
 }
 
-#hero-download-button
-{
-  display: inline-block;
-  min-width: 250px;
-  width: 100;
-}
-
 @media (min-width: 576px)
 {
   #hero-download-button
   {
+    /* force auto-width >= small tablets */
     width: auto;
   }
 }
 
-/** Hide the video border/shadow only when the thumbnail alone is showing */
+#hero-download-video
+{
+  /* add space above on phones & tablets */
+  margin-top: 2em;
+  /* prevent default full-width on small tablets */
+  max-width: 550px;
+}
+
+#hero-download-video
+{
+  /* provide a little space between thumbnail and border + shadow */
+  padding: 1em 1em 0 1em;
+}
+
+@media (min-width: 1024px)
+{
+  #hero-download-video
+  {
+    /* keep aligned-top despite padding below */
+    margin-top: -1em;
+  }
+}
+
+#hero-download-video.has-iframe
+{
+  /* remove space around thumbnail when thumbnail is replaced by video */
+  padding: 0;
+}
+
+/** Hide the video border + shadow only when the thumbnail alone is showing */
 #hero-download-video.hide-disclaimer:not(.has-iframe)
 {
-  border: none;

[ire, 2018/03/13 09:18:02]

The adding/removing of the border causes a shift. 

Suggest: Instead of removing the border here, add a transparent border of the
same width

[juliandoucette, 2018/03/13 14:23:09]

Good catch!

-  box-shadow: none;
-}
-
-/** Add 1em of padding around the thumbnail when the disclaimer is showing */
-#hero-download-video:not(.hide-disclaimer)
-{
-  padding: 1em;
-}
-
-#hero-download-video
-{
-  margin-top: 1em;
-  max-width: 550px;
-}
-
-@media(min-width: 1024px)
-{
-  #hero-download-video
-  {
-    max-width: none;
-    margin-top: 0;
-  }
-}
+  border-color: transparent;
+  /* there is no box-shadow-color property :( */
+  box-shadow: 1px 1px 0 0 transparent;
+}
+
+/* The thumbnail is taller than the video. But it's hard to see because of the
+ * reflection and whitespace at the bottom. As a result, I am cutting out the
+ * whitespace and reflection when I show the disclaimer so that the section
+ * doesn't visibly resize when the thumbnail is replaced by the a iframe.
+ */
+
 
 /******************************************************************************
  * #media
  *****************************************************************************/
 
-#media-section { clear: both; }
-
-#media-header h2,
-#media-list
-{
-  margin: 0;
+#media-section
+{
+  clear: both;
+  text-align: center;
 }
 
 #media-header
 {
-  margin-bottom: 2em;
+  margin-bottom: 1em;
 }
 
 #media-header h2
 {
   font-size: 1em;
   font-weight: normal;
   text-transform: uppercase;
+}
+
+#media-header h2,
+#media-list
+{
+  margin: 0;
 }
 
 #media-list li
 {
   display: inline-block;
 }
 
 #media-list img
 {
   max-width: 10em;
@@ skipping 26 matching lines @@
   border-radius: 50%;
   background-color: #000;
   background-image: url(../img/external-icon.png);
   background-image: linear-gradient(transparent, transparent),
                     url(../img/external-icon.svg);
   background-repeat: no-repeat;
   background-position: center;
   background-size: 1em;
 }
 
-@media (min-width: 992px)
-{
-  #media-header small
-  {
-    display: none;
-  }
-
-  #media-list
-  {
-    display: table;
-    width: 100%;
-  }
-
-  #media-list li
-  {
-    display: table-cell;
-    vertical-align: middle;
-  }
-
-  #media-list img
-  {
-    margin: 0 2em;
-  }
-}
-
-@media (min-width: 768px)
-{
-  #media {
+@media (min-width: 1024px)
+{
+  #media
+  {
     display: table;
     width: 100%;
   }
 
   #media-header,
   #media-list
   {
     display: table-cell;
     vertical-align: middle;
     width: auto;
   }
 
   #media-header
   {
     margin-bottom: 0;
+  }
+
+  #media-header small
+  {
+    display: none;
   }
 
   #media-list { direction: rtl; }
   [dir="rtl"] #media-list { direction: ltr; }
 
   @supports (display: flex)
   {
     #media-list
     {
       display: flex;
       justify-content: space-between;
       align-items: center;
     }
   }
 
+  #media-list
+  {
+    display: table;
+    width: 100%;
+  }
+
+  #media-list li
+  {
+    display: table-cell;
+    vertical-align: middle;
+  }
+
+  #media-list img
+  {
+    margin: 0 2em;
+  }
 }
 
 /******************************************************************************
  * #abb-notification
  *****************************************************************************/
 
 #abb-notification h2,
 #abb-notification h3
 {
   text-transform: uppercase;
@@ skipping 18 matching lines @@
     padding-right: 2em;
   }
 }
 
 /******************************************************************************
  * #footnote
  *****************************************************************************/
 
 #footnote
 {
-  margin-top: 20px;
-  text-align: start;
+  padding-top: 3em;
+  padding-bottom: 2em;
+  font-size: 13px;
   color: #7d7d7d;
 }
-
-#footnote,
-#footnote li,
-#footnote a,
-#footnote strong
-{
-  font-size: 11px;
-}
-
-#footnote li
-{
-  padding-bottom: 5px;
-}
-
-#footnote li:first-child
-{
-  padding-top: 5px;
-}
-
-#footnote ul
-{
-  margin: 0px;
-  padding: 0px 30px;
-}
-
-@media(max-width: 767px)
-{
-  #footnote
-  {
-    padding: 0px 20px;
-  }
-}