Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: static/css/index.css

Issue 29720653: Fixes #30 - Adjustments to hero unit section of index page (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Left Patch Set: Addressed #6 & #7 Created March 14, 2018, 12:38 p.m.
Right Patch Set: Addressed #13 & #14 Created March 14, 2018, 2:51 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « includes/hero-download.html ('k') | static/css/main.css » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /****************************************************************************** 1 /******************************************************************************
2 * Temparary styles 2 * Temparary styles
3 *****************************************************************************/ 3 *****************************************************************************/
4 4
5 .avoid-wrap {display: inline-block;} 5 .avoid-wrap {display: inline-block;}
6 .small {font-size: smaller;} 6 .small {font-size: smaller;}
7 .maxthon-only {display: none;} 7 .maxthon-only {display: none;}
8 .maxthon .maxthon-only {display: block;} 8 .maxthon .maxthon-only {display: block;}
9 9
10 /****************************************************************************** 10 /******************************************************************************
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 { 42 {
43 width: 100%; 43 width: 100%;
44 } 44 }
45 } 45 }
46 46
47 @media (min-width: 1024px) 47 @media (min-width: 1024px)
48 { 48 {
49 #hero-download 49 #hero-download
50 { 50 {
51 padding-top: 6em; 51 padding-top: 6em;
52 /* 3em bottom looks like 6em because of thumbnail contents */ 52 padding-bottom: 6em;
53 padding-bottom: 4em;
54 } 53 }
55 } 54 }
56 55
57 #hero-download h1 56 #hero-download h1
58 { 57 {
59 /* Spacing is provided by the hero-download section */ 58 /* Spacing is provided by the hero-download section */
60 margin-top: 0; 59 margin-top: 0;
61 } 60 }
62 61
63 @media (min-width: 576px) 62 @media (min-width: 576px)
64 { 63 {
65 /* make h1 larger sooner than usual */
66 #hero-download h1
67 {
68 font-size: 2.4em;
69 }
70
71 /* force break without <br> on large screens */ 64 /* force break without <br> on large screens */
72 #hero-download h1 .avoid-wrap:first-of-type 65 #hero-download h1 .avoid-wrap:first-of-type
73 { 66 {
74 display: block; 67 display: block;
75 } 68 }
76 } 69 }
77 70
78 #hero-download-tos 71 #hero-download-tos
79 { 72 {
80 margin-bottom: 0.5em; 73 margin-bottom: 0.5em;
(...skipping 15 matching lines...) Expand all
96 #hero-download-button 89 #hero-download-button
97 { 90 {
98 /* force auto-width >= small tablets */ 91 /* force auto-width >= small tablets */
99 width: auto; 92 width: auto;
100 } 93 }
101 } 94 }
102 95
103 #hero-download-video 96 #hero-download-video
104 { 97 {
105 /* add space above on phones & tablets */ 98 /* add space above on phones & tablets */
106 margin-top: 2em; 99 margin-top: 2em;
juliandoucette 2018/03/14 12:46:31 NIT: Added a little more space here (personal pref
107 /* prevent default full-width on small tablets */ 100 /* prevent default full-width on small tablets */
108 max-width: 550px; 101 max-width: 550px;
109 } 102 }
110 103
111 @media(min-width: 1024px) 104 #hero-download-video
105 {
106 /* provide a little space between thumbnail and border + shadow */
107 padding: 1em 1em 0 1em;
108 }
109
110 @media (min-width: 1024px)
112 { 111 {
113 #hero-download-video 112 #hero-download-video
114 { 113 {
115 /* keep aligned-top despite padding below */ 114 /* keep aligned-top despite padding below */
116 margin-top: -1em; 115 margin-top: -1em;
117 /* provide a little space between thumbnail and border + shadow */
118 padding: 1em;
119 } 116 }
120 } 117 }
121 118
122 #hero-download-video.has-iframe 119 #hero-download-video.has-iframe
123 { 120 {
124 /* remove space around thumbnail when thumbnail is replaced by video */ 121 /* remove space around thumbnail when thumbnail is replaced by video */
125 padding: 0; 122 padding: 0;
126 } 123 }
127 124
128 /** Hide the video border + shadow only when the thumbnail alone is showing */ 125 /** Hide the video border + shadow only when the thumbnail alone is showing */
129 #hero-download-video.hide-disclaimer:not(.has-iframe) 126 #hero-download-video.hide-disclaimer:not(.has-iframe)
130 { 127 {
131 border-color: transparent; 128 border-color: transparent;
132 /* there is no box-shadow-color property :( */ 129 /* there is no box-shadow-color property :( */
133 box-shadow: 1px 1px 0 0 transparent; 130 box-shadow: 1px 1px 0 0 transparent;
134 } 131 }
135 132
136 /* The thumbnail is taller than the video. But it's hard to see because of the 133 /* The thumbnail is taller than the video. But it's hard to see because of the
137 * reflection and whitespace at the bottom. As a result, I am cutting out the 134 * reflection and whitespace at the bottom. As a result, I am cutting out the
138 * whitespace and reflection when I show the disclaimer so that the section 135 * whitespace and reflection when I show the disclaimer so that the section
139 * doesn't visibly resize when the thumbnail is replaced by the a iframe. 136 * doesn't visibly resize when the thumbnail is replaced by the a iframe.
140 */ 137 */
141 138
142 #hero-download-video:not(.hide-disclaimer) .video-thumbnail
143 {
144 margin-bottom: -2.5em;
145 }
146
147 #hero-download-video:not(.hide-disclaimer),
148 #hero-download-video.has-iframe
149 {
150 margin-bottom: 2.5em;
151 }
152 139
153 /****************************************************************************** 140 /******************************************************************************
154 * #media 141 * #media
155 *****************************************************************************/ 142 *****************************************************************************/
156 143
157 #media-section { clear: both; } 144 #media-section
158 145 {
159 #media-header h2, 146 clear: both;
160 #media-list 147 text-align: center;
161 {
162 margin: 0;
163 } 148 }
164 149
165 #media-header 150 #media-header
166 { 151 {
167 margin-bottom: 2em; 152 margin-bottom: 1em;
168 } 153 }
169 154
170 #media-header h2 155 #media-header h2
171 { 156 {
172 font-size: 1em; 157 font-size: 1em;
173 font-weight: normal; 158 font-weight: normal;
174 text-transform: uppercase; 159 text-transform: uppercase;
160 }
161
162 #media-header h2,
163 #media-list
164 {
165 margin: 0;
175 } 166 }
176 167
177 #media-list li 168 #media-list li
178 { 169 {
179 display: inline-block; 170 display: inline-block;
180 } 171 }
181 172
182 #media-list img 173 #media-list img
183 { 174 {
184 max-width: 10em; 175 max-width: 10em;
(...skipping 26 matching lines...) Expand all
211 border-radius: 50%; 202 border-radius: 50%;
212 background-color: #000; 203 background-color: #000;
213 background-image: url(../img/external-icon.png); 204 background-image: url(../img/external-icon.png);
214 background-image: linear-gradient(transparent, transparent), 205 background-image: linear-gradient(transparent, transparent),
215 url(../img/external-icon.svg); 206 url(../img/external-icon.svg);
216 background-repeat: no-repeat; 207 background-repeat: no-repeat;
217 background-position: center; 208 background-position: center;
218 background-size: 1em; 209 background-size: 1em;
219 } 210 }
220 211
221 @media (min-width: 992px) 212 @media (min-width: 1024px)
222 { 213 {
223 #media-header small 214 #media
224 { 215 {
225 display: none;
226 }
227
228 #media-list
229 {
230 display: table;
231 width: 100%;
232 }
233
234 #media-list li
235 {
236 display: table-cell;
237 vertical-align: middle;
238 }
239
240 #media-list img
241 {
242 margin: 0 2em;
243 }
244 }
245
246 @media (min-width: 768px)
247 {
248 #media {
249 display: table; 216 display: table;
250 width: 100%; 217 width: 100%;
251 } 218 }
252 219
253 #media-header, 220 #media-header,
254 #media-list 221 #media-list
255 { 222 {
256 display: table-cell; 223 display: table-cell;
257 vertical-align: middle; 224 vertical-align: middle;
258 width: auto; 225 width: auto;
259 } 226 }
260 227
261 #media-header 228 #media-header
262 { 229 {
263 margin-bottom: 0; 230 margin-bottom: 0;
231 }
232
233 #media-header small
234 {
235 display: none;
264 } 236 }
265 237
266 #media-list { direction: rtl; } 238 #media-list { direction: rtl; }
267 [dir="rtl"] #media-list { direction: ltr; } 239 [dir="rtl"] #media-list { direction: ltr; }
268 240
269 @supports (display: flex) 241 @supports (display: flex)
270 { 242 {
271 #media-list 243 #media-list
272 { 244 {
273 display: flex; 245 display: flex;
274 justify-content: space-between; 246 justify-content: space-between;
275 align-items: center; 247 align-items: center;
276 } 248 }
277 } 249 }
278 250
251 #media-list
252 {
253 display: table;
254 width: 100%;
255 }
256
257 #media-list li
258 {
259 display: table-cell;
260 vertical-align: middle;
261 }
262
263 #media-list img
264 {
265 margin: 0 2em;
266 }
279 } 267 }
280 268
281 /****************************************************************************** 269 /******************************************************************************
282 * #abb-notification 270 * #abb-notification
283 *****************************************************************************/ 271 *****************************************************************************/
284 272
285 #abb-notification h2, 273 #abb-notification h2,
286 #abb-notification h3 274 #abb-notification h3
287 { 275 {
288 text-transform: uppercase; 276 text-transform: uppercase;
(...skipping 18 matching lines...) Expand all
307 padding-right: 2em; 295 padding-right: 2em;
308 } 296 }
309 } 297 }
310 298
311 /****************************************************************************** 299 /******************************************************************************
312 * #footnote 300 * #footnote
313 *****************************************************************************/ 301 *****************************************************************************/
314 302
315 #footnote 303 #footnote
316 { 304 {
317 margin-top: 20px; 305 padding-top: 3em;
318 text-align: start; 306 padding-bottom: 2em;
307 font-size: 13px;
319 color: #7d7d7d; 308 color: #7d7d7d;
320 } 309 }
321
322 #footnote,
323 #footnote li,
324 #footnote a,
325 #footnote strong
326 {
327 font-size: 11px;
328 }
329
330 #footnote li
331 {
332 padding-bottom: 5px;
333 }
334
335 #footnote li:first-child
336 {
337 padding-top: 5px;
338 }
339
340 #footnote ul
341 {
342 margin: 0px;
343 padding: 0px 30px;
344 }
345
346 @media(max-width: 767px)
347 {
348 #footnote
349 {
350 padding: 0px 20px;
351 }
352 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld