Issue 6391 - Allow running the browser unit tests with Firefox

test/runners/chromiumwd_process.js

+/*

[kzar, 2018/05/04 10:52:43]

Since this file (the Chromium WebDriver runner) is pretty similar to the Firefox
WebDriver runner I wonder if they can be combined. Or did you keep them separate
for a reason?

[hub, 2018/05/18 00:04:22]

There are trivial enough that merging them would make them more complicated.

+ * This file is part of Adblock Plus <https://adblockplus.org/>,
+ * Copyright (C) 2006-present eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+"use strict";
+
+const {Builder} = require("selenium-webdriver");
+const chrome = require("selenium-webdriver/chrome");
+require("chromedriver");
+
+const {executeScript} = require("./webdriver");
+const {ensureChromium} = require("./chromium_download");
+
+// Chromium 63.0.3239.x

[kzar, 2018/05/04 10:52:43]

Seems like one of these comments can go?

[hub, 2018/05/18 00:04:22]

Yes and no. It is kinda difficult to figure out which is what so I indicate what
version number to use for Chrome 65. I'll clarify.

+const CHROMIUM_REVISION = 508578;
+// Chromium 65.0.3325.0 is 530368
+
+function runScript(chromiumPath, script, scriptName, scriptArgs)
+{
+  const options = new chrome.Options()
+        .headless()
+        .setChromeBinaryPath(chromiumPath);
+
+  const driver = new Builder()
+        .forBrowser("chrome")
+        .setChromeOptions(options)
+        .build();
+
+  return executeScript(driver, "Chromium (WebDriver)",
+                       script, scriptName, scriptArgs);
+}
+
+module.exports = function(script, scriptName, ...scriptArgs)
+{
+  return ensureChromium(CHROMIUM_REVISION).then(chromiumPath =>
+  {
+    return runScript(chromiumPath, script, scriptName, scriptArgs)
+      .then(result =>
+      {
+        return result;
+      }).catch(error =>
+      {
+        throw error;
+      });
+  });
+};