Issue 6391 - Allow running the browser unit tests with Firefox

test_runner.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 /* eslint-env node */
 
 "use strict";
 
 const fs = require("fs");
 const path = require("path");
 
 const MemoryFS = require("memory-fs");
 const nodeunit = require("nodeunit");
 const webpack = require("webpack");
 
-const chromiumProcess = require("./chromium_process");
+const chromiumRemoteProcess = require("./test/runners/chromium_remote_process");
+const chromiumProcess = require("./test/runners/chromium_process");
+const firefoxProcess = require("./test/runners/firefox_process");
 
 let unitFiles = [];
 let browserFiles = [];
 
+let runnerDefinitions = {
+  // Chromium with chrome-remote-interface
+  chromium_remote: chromiumRemoteProcess,
+  // Chromium with WebDriver (requires Chromium >= 63.0.3239)
+  chromium: chromiumProcess,
+  firefox: firefoxProcess
+};
+
+function configureRunners()
+{
+  let runners = "BROWSER_TEST_RUNNERS" in process.env ?
+      process.env.BROWSER_TEST_RUNNERS.split(",") : [];
+
+  if (runners.length == 0)
+    return ["chromium", "firefox"];
+
+  return runners.filter(runner => runnerDefinitions.hasOwnProperty(runner));
+}
+
+let runnerProcesses = configureRunners();
+
 function addTestPaths(testPaths, recurse)
 {
   for (let testPath of testPaths)
   {
     let stat = fs.statSync(testPath);
     if (stat.isDirectory())
     {
       if (recurse)
       {
         addTestPaths(fs.readdirSync(testPath).map(
@@ skipping 42 matching lines @@
       else
       {
         let bundle = memoryFS.readFileSync("/" + bundleFilename, "utf-8");
         memoryFS.unlinkSync("/" + bundleFilename);
         resolve(bundle);
       }
     });
   });
 }
 
-function runBrowserTests()
+function runBrowserTests(processes)
 {
   if (!browserFiles.length)
     return;
 
   let nodeunitPath = path.join(__dirname, "node_modules", "nodeunit",
                                "examples", "browser", "nodeunit.js");
   let bundleFilename = "bundle.js";
 
   return webpackInMemory(bundleFilename, {
     entry: path.join(__dirname, "test", "browser", "_bootstrap.js"),
     module: {
       rules: [{
         resource: nodeunitPath,
         // I would have rather used exports-loader here, to avoid treating
         // nodeunit as a global. Unfortunately the nodeunit browser example
         // script is quite slopily put together, if exports isn't falsey it
         // breaks! As a workaround we need to use script-loader, which means
         // that exports is falsey for that script as a side-effect.
         use: ["script-loader"]
       }]
     },
     resolve: {
       alias: {
         nodeunit$: nodeunitPath
       },
       modules: [path.resolve(__dirname, "lib")]
     }
   }).then(bundle =>
-  {
-    return chromiumProcess(
-      bundle, bundleFilename,
-      browserFiles.map(
-        file => path.relative(path.join(__dirname, "test", "browser"),
-                              file).replace(/\.js$/, "")
+    Promise.all(
+      processes.map(currentProcess =>
+        runnerDefinitions[currentProcess](
+          bundle, bundleFilename,
+          browserFiles.map(
+            file => path.relative(path.join(__dirname, "test", "browser"),
+                                  file).replace(/\.js$/, "")
+          )
+        )
       )
-    );
-  });
+    )
+  );
 }
 
 if (process.argv.length > 2)
   addTestPaths(process.argv.slice(2), true);
 else
 {
   addTestPaths(
     [path.join(__dirname, "test"), path.join(__dirname, "test", "browser")],
     true
   );
 }
 
-Promise.resolve(runBrowserTests()).catch(error =>
+Promise.resolve(runBrowserTests(runnerProcesses)).catch(error =>
 {
   console.error("Failed running browser tests");
   console.error(error);
 }).then(() =>
 {
   if (unitFiles.length)
     nodeunit.reporters.default.run(unitFiles);
 });