Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: README.md

Issue 29720661: Issue 6391 - Allow running the browser unit tests with Firefox (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Update Firefox version in README Created Aug. 3, 2018, 4:15 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « .hgignore ('k') | package.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: README.md
--- a/README.md
+++ b/README.md
@@ -25,16 +25,27 @@
You can specify specific test files or directories on the command line, e.g.:
`npm test test/synchronizer.js test/browser/elemHideEmulation.js`.
### Running the browser tests in a real browser
The tests under `test/browser` require a browser environment. `npm test` will
run these in a headless browser, with each module being loaded in a new frame.
+The default is to run in both Chromium (using the remote interface)
+and Firefox. You can select which runners to use by setting the
+BROWSER_TEST_RUNNERS environment, the default is
+"chromium_remote,firefox". Possible values (separated by a ',') are:
+- "chromium_remote": Chromium 60 (using the remote interface)
+- "chromium": Chrome 63 (using WebDriver)
+- "firefox": Firefox 56 (using WebDriver)
+You can not set a specific version of the browser at runtime.
You can lint the code using [ESLint](http://eslint.org).
eslint *.js chrome lib test
You will need to set up ESLint and our configuration first, see
« no previous file with comments | « .hgignore ('k') | package.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld