Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(662)

Issue 29721690: ABP: Issue 6262 - Moved Favicon framework to different build configuration path to prevent crashing… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 1 week ago by a.shephard
Modified:
6 months, 1 week ago
Reviewers:
dean, d108
Visibility:
Public.

Description

ABP: Issue 6262 - Moved Favicon framework to different build configuration path to prevent crashing…

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M AdblockPlusSafari.xcodeproj/project.pbxproj View 6 chunks +5 lines, -9 lines 0 comments Download
M Cartfile.resolved View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
a.shephard
6 months, 1 week ago (2018-03-13 15:53:38 UTC) #1
d108
On 2018/03/13 15:53:38, a.shephard wrote: LGTM - but please give the Frameworks group a sort ...
6 months, 1 week ago (2018-03-14 01:57:42 UTC) #2
dean
On 2018/03/14 01:57:42, d108 wrote: > On 2018/03/13 15:53:38, a.shephard wrote: > > LGTM - ...
6 months, 1 week ago (2018-03-14 15:01:45 UTC) #3
a.shephard
6 months, 1 week ago (2018-03-15 08:46:57 UTC) #4
Sorted and landed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5