Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(577)

Issue 29721720: Fixes #32 - Adjustments to cross-promotion section (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 1 week ago by juliandoucette
Modified:
6 months, 1 week ago
Reviewers:
ire
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Please see https://gitlab.com/eyeo/websites/web.adblockplus.org/issues/32#note_63026898 before reviewing.

Patch Set 1 #

Patch Set 2 : Addressed note_63196626 #

Patch Set 3 : Rebased #

Patch Set 4 : Removed global font-size change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
M includes/cross-promotion.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M locales/en/abb-notification.json View 1 chunk +1 line, -1 line 0 comments Download
M static/css/index.css View 1 2 1 chunk +30 lines, -1 line 0 comments Download

Messages

Total messages: 9
juliandoucette
6 months, 1 week ago (2018-03-13 16:55:46 UTC) #1
juliandoucette
Please see https://gitlab.com/eyeo/websites/web.adblockplus.org/issues/32#note_63026898 before reviewing.
6 months, 1 week ago (2018-03-13 16:56:02 UTC) #2
ire
On 2018/03/13 16:56:02, juliandoucette wrote: > Please see > https://gitlab.com/eyeo/websites/web.adblockplus.org/issues/32#note_63026898 > before reviewing. Ack
6 months, 1 week ago (2018-03-14 07:57:47 UTC) #3
juliandoucette
New Patchset up! (It's ready to be reviewed now) Detail: I added another layer of ...
6 months, 1 week ago (2018-03-14 12:27:33 UTC) #4
juliandoucette
On 2018/03/14 12:27:33, juliandoucette wrote: > Detail: I added another layer of responsiveness to heading ...
6 months, 1 week ago (2018-03-14 12:48:34 UTC) #5
ire
@jeen: > @juliandoucette for the phones I would reduce the line height by 0.5em and ...
6 months, 1 week ago (2018-03-14 13:17:11 UTC) #6
juliandoucette
On 2018/03/14 13:17:11, ire wrote: > You didn't address this? See my last two replies ...
6 months, 1 week ago (2018-03-14 13:55:46 UTC) #7
ire
On 2018/03/14 13:55:46, juliandoucette wrote: > On 2018/03/14 13:17:11, ire wrote: > > You didn't ...
6 months, 1 week ago (2018-03-14 14:12:39 UTC) #8
juliandoucette
6 months, 1 week ago (2018-03-14 14:58:40 UTC) #9

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5