Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: static/css/index.css

Issue 29721780: Fixes #33 - Adjustments to features section of index page (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Left Patch Set: Created March 13, 2018, 8:44 p.m.
Right Patch Set: Addressed #5 Created March 14, 2018, 1:54 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « includes/features.html ('k') | static/css/main.css » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /****************************************************************************** 1 /******************************************************************************
2 * Temparary styles 2 * Temparary styles
3 *****************************************************************************/ 3 *****************************************************************************/
4 4
5 .avoid-wrap {display: inline-block;} 5 .avoid-wrap {display: inline-block;}
6 .small {font-size: smaller;} 6 .small {font-size: smaller;}
7 .maxthon-only {display: none;} 7 .maxthon-only {display: none;}
8 .maxthon .maxthon-only {display: block;} 8 .maxthon .maxthon-only {display: block;}
9 9
10 #content, 10 #content,
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 #hero-download-video 66 #hero-download-video
67 { 67 {
68 display: block; 68 display: block;
69 } 69 }
70 } 70 }
71 71
72 /****************************************************************************** 72 /******************************************************************************
73 * #media 73 * #media
74 *****************************************************************************/ 74 *****************************************************************************/
75 75
76 #media-section { clear: both; } 76 #media-section
77 77 {
78 #media-header h2, 78 clear: both;
79 #media-list 79 text-align: center;
80 {
81 margin: 0;
82 } 80 }
83 81
84 #media-header 82 #media-header
85 { 83 {
86 margin-bottom: 2em; 84 margin-bottom: 1em;
87 } 85 }
88 86
89 #media-header h2 87 #media-header h2
90 { 88 {
91 font-size: 1em; 89 font-size: 1em;
92 font-weight: normal; 90 font-weight: normal;
93 text-transform: uppercase; 91 text-transform: uppercase;
92 }
93
94 #media-header h2,
95 #media-list
96 {
97 margin: 0;
94 } 98 }
95 99
96 #media-list li 100 #media-list li
97 { 101 {
98 display: inline-block; 102 display: inline-block;
99 } 103 }
100 104
101 #media-list img 105 #media-list img
102 { 106 {
103 max-width: 10em; 107 max-width: 10em;
(...skipping 26 matching lines...) Expand all
130 border-radius: 50%; 134 border-radius: 50%;
131 background-color: #000; 135 background-color: #000;
132 background-image: url(../img/external-icon.png); 136 background-image: url(../img/external-icon.png);
133 background-image: linear-gradient(transparent, transparent), 137 background-image: linear-gradient(transparent, transparent),
134 url(../img/external-icon.svg); 138 url(../img/external-icon.svg);
135 background-repeat: no-repeat; 139 background-repeat: no-repeat;
136 background-position: center; 140 background-position: center;
137 background-size: 1em; 141 background-size: 1em;
138 } 142 }
139 143
140 @media (min-width: 992px) 144 @media (min-width: 1024px)
141 { 145 {
142 #media-header small 146 #media
143 { 147 {
144 display: none;
145 }
146
147 #media-list
148 {
149 display: table;
150 width: 100%;
151 }
152
153 #media-list li
154 {
155 display: table-cell;
156 vertical-align: middle;
157 }
158
159 #media-list img
160 {
161 margin: 0 2em;
162 }
163 }
164
165 @media (min-width: 768px)
166 {
167 #media {
168 display: table; 148 display: table;
169 width: 100%; 149 width: 100%;
170 } 150 }
171 151
172 #media-header, 152 #media-header,
173 #media-list 153 #media-list
174 { 154 {
175 display: table-cell; 155 display: table-cell;
176 vertical-align: middle; 156 vertical-align: middle;
177 width: auto; 157 width: auto;
178 } 158 }
179 159
180 #media-header 160 #media-header
181 { 161 {
182 margin-bottom: 0; 162 margin-bottom: 0;
163 }
164
165 #media-header small
166 {
167 display: none;
183 } 168 }
184 169
185 #media-list { direction: rtl; } 170 #media-list { direction: rtl; }
186 [dir="rtl"] #media-list { direction: ltr; } 171 [dir="rtl"] #media-list { direction: ltr; }
187 172
188 @supports (display: flex) 173 @supports (display: flex)
189 { 174 {
190 #media-list 175 #media-list
191 { 176 {
192 display: flex; 177 display: flex;
193 justify-content: space-between; 178 justify-content: space-between;
194 align-items: center; 179 align-items: center;
195 } 180 }
196 } 181 }
182
183 #media-list
184 {
185 display: table;
186 width: 100%;
187 }
188
189 #media-list li
190 {
191 display: table-cell;
192 vertical-align: middle;
193 }
194
195 #media-list img
196 {
197 margin: 0 2em;
198 }
197 } 199 }
198 200
199 /****************************************************************************** 201 /******************************************************************************
200 * #features 202 * #features
ire 2018/03/14 08:44:01 TOL: I'm working on the download page, and I think
juliandoucette 2018/03/14 11:50:37 Acknowledged. I'd encourage you to change this if
ire 2018/03/14 13:07:42 Sure. I'll confirm from Jeen, and handle this in t
201 *****************************************************************************/ 203 *****************************************************************************/
202 204
203 #features 205 #features
204 { 206 {
205 text-align: center; 207 text-align: center;
206 padding-top: 3em; 208 padding-top: 3em;
207 padding-bottom: 3em; 209 padding-bottom: 3em;
208 } 210 }
209 211
210 #features h2 212 #features h2
(...skipping 14 matching lines...) Expand all
225 } 227 }
226 } 228 }
227 229
228 @media (min-width: 576px) and (max-width: 1023px) 230 @media (min-width: 576px) and (max-width: 1023px)
229 { 231 {
230 #features 232 #features
231 { 233 {
232 text-align: left; 234 text-align: left;
233 } 235 }
234 236
237 [dir="rtl"] #features
238 {
239 text-align: right;
240 }
241
235 #features .column 242 #features .column
236 { 243 {
237 position: relative; 244 position: relative;
238 width: auto; 245 width: auto;
239 padding: 0 3em 2em 10.5em; 246 padding: 0 3em 2em 10.5em;
ire 2018/03/14 08:21:39 This spacing only works for LTR
ire 2018/03/14 08:21:39 The bottom spacing here is causing > 3em spacing i
juliandoucette 2018/03/14 11:50:37 Done. Good catch.
juliandoucette 2018/03/14 11:50:37 Done. Good catch.
240 } 247 }
241 248
249 [dir="rtl"] #features .column
250 {
251 padding: 0 10.5em 2em 3em;
252 }
253
254 #features .column:last-of-type
255 {
256 padding-bottom: 0;
257 }
258
242 #features img 259 #features img
243 { 260 {
244 position: absolute; 261 position: absolute;
245 left: 3em; 262 left: 3em;
246 top: 0.5em; 263 top: 0.5em;
247 } 264 }
248 265
249 [dir="rtl"] #features img 266 [dir="rtl"] #features img
250 { 267 {
251 left: auto; 268 left: auto;
252 right: 0; 269 right: 3em;
ire 2018/03/14 08:21:39 right should be 3em
juliandoucette 2018/03/14 11:50:37 Done. Good catch.
253 } 270 }
254 271
255 #features h2 272 #features h2
256 { 273 {
257 margin: 0; 274 margin: 0;
258 } 275 }
259 } 276 }
260 277
261 /****************************************************************************** 278 /******************************************************************************
262 * #abb-notification 279 * #abb-notification
(...skipping 24 matching lines...) Expand all
287 padding-right: 2em; 304 padding-right: 2em;
288 } 305 }
289 } 306 }
290 307
291 /****************************************************************************** 308 /******************************************************************************
292 * #footnote 309 * #footnote
293 *****************************************************************************/ 310 *****************************************************************************/
294 311
295 #footnote 312 #footnote
296 { 313 {
297 margin-top: 20px; 314 padding-top: 3em;
298 text-align: start; 315 padding-bottom: 2em;
316 font-size: 13px;
299 color: #7d7d7d; 317 color: #7d7d7d;
300 } 318 }
301
302 #footnote,
303 #footnote li,
304 #footnote a,
305 #footnote strong
306 {
307 font-size: 11px;
308 }
309
310 #footnote li
311 {
312 padding-bottom: 5px;
313 }
314
315 #footnote li:first-child
316 {
317 padding-top: 5px;
318 }
319
320 #footnote ul
321 {
322 margin: 0px;
323 padding: 0px 30px;
324 }
325
326 @media(max-width: 767px)
327 {
328 #footnote
329 {
330 padding: 0px 20px;
331 }
332 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld