Side by Side Diff: static/css/uninstalled.css
Issue 29721785:
Fixes #29 - Moved reinstall banner below heading on uninstalled pages (Closed)
Base URL: https://hg.adblockplus.org/web.adblockplus.org
Patch Set: Adjusted spacing and refactored button to accomodate other languages
Created March 13, 2018, 9:42 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« static/css/main.css ('k')
|
no next file »
|
no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| OLD | NEW |
|---|---|
| 1 /* #reinstall | 1 /* #reinstall |
| 2 ******************************************************************************/ | 2 ******************************************************************************/ |
| 3 | 3 |
| 4 #reinstall | 4 #reinstall |
| 5 { | 5 { |
| 6 padding: 1em 0; | 6 font-size: 1.1em; |
|
ire
2018/03/14 08:34:29
Why did you pick these font sizes? Also, why did y
juliandoucette
2018/03/14 12:02:27
- So that the text and button fit comfortably on o
ire
2018/03/14 13:10:21
Ack.
| |
| 7 } | |
| 8 | |
| 9 #reinstall-label | |
| 10 { | |
| 11 /* Adds space above preceeding heading on small screens */ | |
|
ire
2018/03/14 08:34:29
Suggest: Add top&bottom padding to the #reinstall
juliandoucette
2018/03/14 12:02:27
Done.
Good idea!
| |
| 12 display: inline-block; | |
| 13 margin-top: 1em; | |
| 14 margin-right: 1em; | |
| 7 } | 15 } |
| 8 | 16 |
| 9 #reinstall .button | 17 #reinstall .button |
| 10 { | 18 { |
| 11 margin: 1em 0; | 19 /* Adds space around section on large screens and button on small screens */ |
| 20 margin-top: 1em; | |
| 21 margin-bottom: 1em; | |
| 12 } | 22 } |
| 13 | 23 |
| 14 @media(min-width: 768px) | 24 @media (min-width: 768px) |
| 15 { | 25 { |
| 16 #reinstall .button | 26 #reinstall |
| 17 { | 27 { |
| 18 margin-left: 1.5em; | 28 font-size: 1.2em; |
| 19 } | |
| 20 | |
| 21 [dir="rtl"] #reinstall .button | |
| 22 { | |
| 23 margin-right: 1.5em; | |
| 24 } | 29 } |
| 25 } | 30 } |
| 26 | 31 |
| 27 | |
| 28 /* #uninstall-reasons | 32 /* #uninstall-reasons |
| 29 ******************************************************************************/ | 33 ******************************************************************************/ |
| 30 | 34 |
| 35 #uninstall-reasons h1 | |
| 36 { | |
| 37 margin-bottom: 0; | |
|
ire
2018/03/14 08:34:29
This doesn't have any effect
juliandoucette
2018/03/14 12:02:27
Done.
Good catch.
| |
| 38 } | |
| 39 | |
| 31 #uninstall-reasons ul | 40 #uninstall-reasons ul |
| 32 { | 41 { |
| 33 list-style-type: none; | 42 list-style-type: none; |
| 43 margin: 0; | |
| 34 } | 44 } |
| 35 | 45 |
| 36 #uninstall-reasons ul, | 46 #uninstall-reasons ul, |
| 37 #uninstall-reasons li | 47 #uninstall-reasons li |
| 38 { | 48 { |
| 39 padding-left: 0; | 49 padding-left: 0; |
| 40 margin-bottom: 0.5em; | 50 margin-bottom: 0.5em; |
| 41 } | 51 } |
| 42 | 52 |
| 43 [dir="rtl"] #uninstall-reasons ul, | 53 [dir="rtl"] #uninstall-reasons ul, |
| (...skipping 27 matching lines...) Expand all Loading... | |
| 71 | 81 |
| 72 .error #reason-error | 82 .error #reason-error |
| 73 { | 83 { |
| 74 display: block; | 84 display: block; |
| 75 } | 85 } |
| 76 | 86 |
| 77 .hidden | 87 .hidden |
| 78 { | 88 { |
| 79 display: none; | 89 display: none; |
| 80 } | 90 } |
| OLD | NEW |
« no previous file with comments
|
« static/css/main.css ('k')
|
no next file »
|
no next file with comments »
