Delta Between Two Patch Sets: static/css/uninstalled.css
Issue 29721785:
Fixes #29 - Moved reinstall banner below heading on uninstalled pages (Closed)
Base URL: https://hg.adblockplus.org/web.adblockplus.org
Left Patch Set: Adjusted spacing and refactored button to accomodate other languages
Created March 13, 2018, 9:42 p.m.
Right Patch Set: Addressed #3
Created March 14, 2018, 12:02 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« static/css/main.css ('k')
|
no next file »
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 /* #reinstall | 1 /* #reinstall |
| 2 ******************************************************************************/ | 2 ******************************************************************************/ |
| 3 | 3 |
| 4 #reinstall | 4 #reinstall |
| 5 { | 5 { |
| 6 margin-top: 1em; | |
| 7 margin-bottom: 1em; | |
| 6 font-size: 1.1em; | 8 font-size: 1.1em; |
|
ire
2018/03/14 08:34:29
Why did you pick these font sizes? Also, why did y
juliandoucette
2018/03/14 12:02:27
- So that the text and button fit comfortably on o
ire
2018/03/14 13:10:21
Ack.
| |
| 7 } | 9 } |
| 8 | 10 |
| 9 #reinstall-label | 11 #reinstall-label |
| 10 { | 12 { |
| 11 /* Adds space above preceeding heading on small screens */ | |
|
ire
2018/03/14 08:34:29
Suggest: Add top&bottom padding to the #reinstall
juliandoucette
2018/03/14 12:02:27
Done.
Good idea!
| |
| 12 display: inline-block; | 13 display: inline-block; |
| 13 margin-top: 1em; | 14 margin-bottom: 1em; |
| 14 margin-right: 1em; | 15 margin-right: 1em; |
| 15 } | |
| 16 | |
| 17 #reinstall .button | |
| 18 { | |
| 19 /* Adds space around section on large screens and button on small screens */ | |
| 20 margin-top: 1em; | |
| 21 margin-bottom: 1em; | |
| 22 } | 16 } |
| 23 | 17 |
| 24 @media (min-width: 768px) | 18 @media (min-width: 768px) |
| 25 { | 19 { |
| 26 #reinstall | 20 #reinstall |
| 27 { | 21 { |
| 28 font-size: 1.2em; | 22 font-size: 1.2em; |
| 29 } | 23 } |
| 30 } | 24 } |
| 31 | 25 |
| 32 /* #uninstall-reasons | 26 /* #uninstall-reasons |
| 33 ******************************************************************************/ | 27 ******************************************************************************/ |
| 34 | |
| 35 #uninstall-reasons h1 | |
| 36 { | |
| 37 margin-bottom: 0; | |
|
ire
2018/03/14 08:34:29
This doesn't have any effect
juliandoucette
2018/03/14 12:02:27
Done.
Good catch.
| |
| 38 } | |
| 39 | 28 |
| 40 #uninstall-reasons ul | 29 #uninstall-reasons ul |
| 41 { | 30 { |
| 42 list-style-type: none; | 31 list-style-type: none; |
| 43 margin: 0; | 32 margin: 0; |
| 44 } | 33 } |
| 45 | 34 |
| 46 #uninstall-reasons ul, | 35 #uninstall-reasons ul, |
| 47 #uninstall-reasons li | 36 #uninstall-reasons li |
| 48 { | 37 { |
| (...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 81 | 70 |
| 82 .error #reason-error | 71 .error #reason-error |
| 83 { | 72 { |
| 84 display: block; | 73 display: block; |
| 85 } | 74 } |
| 86 | 75 |
| 87 .hidden | 76 .hidden |
| 88 { | 77 { |
| 89 display: none; | 78 display: none; |
| 90 } | 79 } |
| LEFT | RIGHT |
« static/css/main.css ('k')
|
no next file »
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
