Unified Diff: static/css/uninstalled.css
Issue 29721785:
Fixes #29 - Moved reinstall banner below heading on uninstalled pages (Closed)
Base URL: https://hg.adblockplus.org/web.adblockplus.org
Patch Set: Adjusted spacing and refactored button to accomodate other languages
Created March 13, 2018, 9:42 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« static/css/main.css ('k')
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: static/css/uninstalled.css |
| =================================================================== |
| --- a/static/css/uninstalled.css |
| +++ b/static/css/uninstalled.css |
| @@ -1,41 +1,51 @@ |
| /* #reinstall |
| ******************************************************************************/ |
| #reinstall |
| { |
| - padding: 1em 0; |
| + font-size: 1.1em; |
|
ire
2018/03/14 08:34:29
Why did you pick these font sizes? Also, why did y
juliandoucette
2018/03/14 12:02:27
- So that the text and button fit comfortably on o
ire
2018/03/14 13:10:21
Ack.
|
| +} |
| + |
| +#reinstall-label |
| +{ |
| + /* Adds space above preceeding heading on small screens */ |
|
ire
2018/03/14 08:34:29
Suggest: Add top&bottom padding to the #reinstall
juliandoucette
2018/03/14 12:02:27
Done.
Good idea!
|
| + display: inline-block; |
| + margin-top: 1em; |
| + margin-right: 1em; |
| } |
| #reinstall .button |
| { |
| - margin: 1em 0; |
| + /* Adds space around section on large screens and button on small screens */ |
| + margin-top: 1em; |
| + margin-bottom: 1em; |
| } |
| -@media(min-width: 768px) |
| +@media (min-width: 768px) |
| { |
| - #reinstall .button |
| + #reinstall |
| { |
| - margin-left: 1.5em; |
| - } |
| - |
| - [dir="rtl"] #reinstall .button |
| - { |
| - margin-right: 1.5em; |
| + font-size: 1.2em; |
| } |
| } |
| - |
| /* #uninstall-reasons |
| ******************************************************************************/ |
| +#uninstall-reasons h1 |
| +{ |
| + margin-bottom: 0; |
|
ire
2018/03/14 08:34:29
This doesn't have any effect
juliandoucette
2018/03/14 12:02:27
Done.
Good catch.
|
| +} |
| + |
| #uninstall-reasons ul |
| { |
| list-style-type: none; |
| + margin: 0; |
| } |
| #uninstall-reasons ul, |
| #uninstall-reasons li |
| { |
| padding-left: 0; |
| margin-bottom: 0.5em; |
| } |
« no previous file with comments
|
« static/css/main.css ('k')
|
no next file »
|
no next file with comments »
