pages/download.tmpl - Issue 29722640: Fixes #22 - Add download page

Side by Side Diff: pages/download.tmpl

Issue 29722640: Fixes #22 - Add download page (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org

Patch Set: Created March 14, 2018, 1:31 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 title=Download Adblock Plus

	2 description=Get Adblock Plus for free on Firefox, Chrome, Opera, Safari, Android and iOS
	ire 2018/03/14 13:34:37 The title & description aren't in the spec yet. The title & description aren't in the spec yet. See https://gitlab.com/eyeo/websites/web.adblockplus.org/issues/22#note_63233215 juliandoucette 2018/03/14 17:54:53 Acknowledged. Show quoted text On 2018/03/14 13:34:37, ire wrote: > The title & description aren't in the spec yet. > > See https://gitlab.com/eyeo/websites/web.adblockplus.org/issues/22#note_63233215 Acknowledged.
	3 template=minimal

	4

	5 <head>

	6 <style>

	7 header img {

	8 width: 4em;

	9 height: auto;

	10 }

	11 </style>

	12 </head>

	13

	14 {% set supported_devices = [

	15 {

	16 "icons": ["device-desktop.png", "device-desktop-2x.png"],

	17 "icon_alt": "Computer monitor and mouse icon",

	18 "title": "Block ads on any desktop browser",

	19 "description": "By clicking any of the links below, you agree to our <a href =\"terms\">Terms of Use</a>",
	juliandoucette 2018/03/14 17:54:53 Missing period. Missing period. ire 2018/03/15 09:38:12 Done. Show quoted text On 2018/03/14 17:54:53, juliandoucette wrote: > Missing period. Done.
	20 "platforms": [

	21 { "name": "Chrome", "url": "https://chrome.google.com/webstore/detail/cfhd ojbkjhnklbpkdaibdccddilifddb" },

	22 { "name": "Firefox", "url": "https://update.adblockplus.org/latest/adblock plusfirefox.xpi" },

	23 { "name": "Internet Explorer", "url": "https://update.adblockplus.org/late st/adblockplusie.exe" },

	24 { "name": "Safari", "url": "https://update.adblockplus.org/latest/adblockp lussafari.safariextz" },

	25 { "name": "Edge (beta)", "url": "https://www.microsoft.com/store/p/adblock -plus/9nblggh4r9nz" },

	26 { "name": "Opera", "url": "https://addons.opera.com/extensions/details/ope ra-adblock/?display=en-US" },

	27 { "name": "Maxthon", "url": "http://www.maxthon.com/mx5/features/ad-blocke r/" },

	28 { "name": "Yandex Browser", "url": "https://chrome.google.com/webstore/det ail/cfhdojbkjhnklbpkdaibdccddilifddb" }

	29 ]

	30 },

	31 {

	32 "icons": ["device-mobile.png", "device-mobile.svg"],

	33 "icon_alt": "Mobile icon",

	34 "title": "Block ads on your mobile browser",

	35 "platforms": [

	36 { "name": "Samsung Internet (Android)", "url": "https://play.google.com/st ore/apps/details?id=org.adblockplus.adblockplussbrowser&hl" },

	37 { "name": "Safari (iOS)", "url": "https://itunes.apple.com/app/adblock-plu s-abp-remove-ads-browse-faster-without-tracking/id1028871868?mt=8" },

	38 { "name": "Firefox", "url": "https://addons.mozilla.org/android/addon/adbl ock-plus/" }

	39 ]

	40 },

	41 {

	42 "icons": ["abb-icon.png", "abb-icon-2x.png"],

	43 "icon_alt": "Adblock Browser logo",

	44 "title": "Block ads in a dedicated ad-blocking browser",

	45 "platforms": [

	46 { "name": "Adblock Browser (Android)", "url": "https://play.google.com/sto re/apps/details?id=org.adblockplus.browser" },

	47 { "name": "Adblock Browser (iOS)", "url": "https://itunes.apple.com/my/app /adblock-browser/id1015653330?mt=8&ign-itsct=1015653330-1015653330&ign-itscg=017 6&ign-mpt=uo%3D4" }

	48 ]

	49 }

	50 ] %}

	51

	52 <header class="bg-primary section content text-center">

	53 <div class="container">

	54 <img height="90px"

	55 width="90px"

	56 src="/img/download-icon.png"

	57 srcset="/img/download-icon.svg 2x"

	58 alt="White down arrow">
	juliandoucette 2018/03/14 17:54:52 Missing translation. Missing translation. ire 2018/03/15 09:38:11 Done. Show quoted text On 2018/03/14 17:54:52, juliandoucette wrote: > Missing translation. Done.
	59 <h1>{{ "Get Adblock Plus products on these devices" \| translate("download-he ading") }}</h1>
	juliandoucette 2018/03/14 17:54:52 Missing string context (heading). Missing string context (heading). ire 2018/03/15 09:38:12 Done. Show quoted text On 2018/03/14 17:54:52, juliandoucette wrote: > Missing string context (heading). Done.
	60 <p>{{ "Supported platforms" \| translate("download-subheading") }}</p>
	juliandoucette 2018/03/14 17:54:52 Missing string context (subheading). Missing string context (subheading). ire 2018/03/15 09:38:12 Done. Show quoted text On 2018/03/14 17:54:52, juliandoucette wrote: > Missing string context (subheading). Done.
	61 </div>

	62 </header>

	63

	64 <div class="container text-center content">
	juliandoucette 2018/03/14 17:54:52 Suggest: section class? Suggest: section class? ire 2018/03/15 09:38:11 That would create a different sectioning context. Show quoted text On 2018/03/14 17:54:52, juliandoucette wrote: > Suggest: section class? That would create a different sectioning context. Also, there would be no heading for this section.
	65 <div class="row item-group">
	ire 2018/03/14 13:34:37 Until we push your features review, I'm using the Until we push your features review, I'm using the item-group layout here juliandoucette 2018/03/14 17:54:52 Acknowledged. Show quoted text On 2018/03/14 13:34:37, ire wrote: > Until we push your features review, I'm using the item-group layout here Acknowledged.
	66 {% for device in supported_devices %}

	67 <div class="column one-third item">

	68 <img

	69 height="90px"

	70 width="90px"

	71 src="/img/{{ device.icons[0] }}"

	72 srcset="/img/{{ device.icons[1] }} 2x"

	73 alt="{{ device.icon_alt }}">
	juliandoucette 2018/03/14 17:54:53 Missing translation. Missing translation. ire 2018/03/15 09:38:11 Done. Show quoted text On 2018/03/14 17:54:53, juliandoucette wrote: > Missing translation. Done.
	74 <h2 class="item-heading">{{ device.title }}</h2>
	juliandoucette 2018/03/14 17:54:52 Missing translation. Missing translation. ire 2018/03/15 09:38:11 Done. Show quoted text On 2018/03/14 17:54:52, juliandoucette wrote: > Missing translation. Done.
	75 <div class="item-body">

	76 <p>{{ device.description \| safe }}</p>
	juliandoucette 2018/03/14 17:54:52 Missing translation. I didn't know "\| safe" was a Missing translation. I didn't know "\| safe" was a thing... Cool. ire 2018/03/15 09:38:11 Done. Show quoted text On 2018/03/14 17:54:52, juliandoucette wrote: > Missing translation. Done. Show quoted text > I didn't know "\| safe" was a thing... Cool. Yeah!
	77 <ul class="horizontal-list">
	juliandoucette 2018/03/14 17:54:53 Detail: We may consider optimizing these links usi Detail: We may consider optimizing these links using a schema e.g. Product (Can be done separately.)
	78 {% for platform in device.platforms %}

	79 <li>
	juliandoucette 2018/03/14 17:54:53 See https://gitlab.com/eyeo/specs/spec/merge_reque See https://gitlab.com/eyeo/specs/spec/merge_requests/135#note_63279602 ire 2018/03/15 09:38:12 Done. Show quoted text On 2018/03/14 17:54:53, juliandoucette wrote: > See https://gitlab.com/eyeo/specs/spec/merge_requests/135#note_63279602 Done.
	80 <a href="{{ platform.url }}">{{ platform.name }}</a>{{ ", " if loo p.index != loop.length }}
	juliandoucette 2018/03/14 17:54:52 Missing translation. Missing translation. juliandoucette 2018/03/14 17:54:52 Detail: We may consider optimizing these link labe Detail: We may consider optimizing these link labels and/or titles for search engines e.g. "Adblock Plus for Samsung browser" is better than "Samsung browser". (Can be done separately.) ire 2018/03/15 09:38:11 Done. Show quoted text On 2018/03/14 17:54:52, juliandoucette wrote: > Missing translation. Done.
	81 </li>

	82 {% endfor %}

	83 </ul>

	84 </div>

	85 </div>

	86 {% endfor %}

	87 </div>

	88 </div>

OLD	NEW

« no previous file with comments | « no previous file | static/css/main.css » ('j') | static/css/main.css » ('J')