pages/download.tmpl - Issue 29722640: Fixes #22 - Add download page

Unified Diff: pages/download.tmpl

Issue 29722640: Fixes #22 - Add download page (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org

Patch Set: Addressed comments #3 Created March 15, 2018, 9:30 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Index: pages/download.tmpl

===================================================================

new file mode 100644

--- /dev/null

+++ b/pages/download.tmpl

@@ -0,0 +1,94 @@

+title=Download Adblock Plus

saroyanm 2018/03/19 19:04:07 I assume having 2 steps installation from the home

ire 2018/03/20 07:25:26 This download page is more of a fallback in case t

saroyanm 2018/03/23 18:33:38 Noted

+description=Get Adblock Plus for free on Firefox, Chrome, Opera, Safari, Android and iOS

+template=minimal

+<head>

+ <style>

+ header img {

+ width: 4em;

+ height: auto;

+ }

+ </style>

+</head>

+{% set supported_devices = [

+ {

+ "id": "desktop",

+ "icons": ["device-desktop.png", "device-desktop-2x.png"],

+ "icon_alt": "Computer monitor and mouse icon",

+ "title": "Block ads on any desktop browser",

+ "description": "By clicking any of the links below, you agree to our <a href=\"terms\">Terms of Use</a>.",

saroyanm 2018/03/19 19:04:07 Detail: We used to use a special function when we

ire 2018/03/20 07:25:25 Good suggestion! Done.

+ "platforms": [

+ { "name": "Chrome", "url": "https://chrome.google.com/webstore/detail/cfhdojbkjhnklbpkdaibdccddilifddb" },

saroyanm 2018/03/19 19:04:07 Is that intentional that we are not using inline i

ire 2018/03/20 07:25:25 I will bring this up with Jeen

ire 2018/03/20 14:40:58 From Jeen's response it seems like the links here

saroyanm 2018/03/23 18:33:38 Yes, but in order the inline installation for the

ire 2018/03/26 07:29:07 Okay I think I was mixing up two different things

ire 2018/03/26 09:44:27 So Jeen confirmed that we are not using inline ins

+ { "name": "Firefox", "url": "https://update.adblockplus.org/latest/adblockplusfirefox.xpi" },

+ { "name": "Internet Explorer", "url": "https://update.adblockplus.org/latest/adblockplusie.exe" },

+ { "name": "Safari", "url": "https://update.adblockplus.org/latest/adblockplussafari.safariextz" },

+ { "name": "Edge (beta)", "url": "https://www.microsoft.com/store/p/adblock-plus/9nblggh4r9nz" },

+ { "name": "Opera", "url": "https://addons.opera.com/extensions/details/opera-adblock/?display=en-US" },

saroyanm 2018/03/19 19:04:07 Detail: No need to use language specific version o

ire 2018/03/20 07:25:26 Done.

+ { "name": "Maxthon", "url": "http://www.maxthon.com/mx5/features/ad-blocker/" },

+ { "name": "Yandex Browser", "url": "https://chrome.google.com/webstore/detail/cfhdojbkjhnklbpkdaibdccddilifddb" }

+ ]

+ },

+ {

+ "id": "mobile",

+ "icons": ["device-mobile.png", "device-mobile.svg"],

+ "icon_alt": "Mobile icon",

+ "title": "Block ads in your mobile browser",

+ "platforms": [

+ { "name": "Samsung Internet (Android)", "url": "https://play.google.com/store/apps/details?id=org.adblockplus.adblockplussbrowser&hl" },

+ { "name": "Safari (iOS)", "url": "https://itunes.apple.com/app/adblock-plus-abp-remove-ads-browse-faster-without-tracking/id1028871868?mt=8" },

+ { "name": "Firefox", "url": "https://addons.mozilla.org/android/addon/adblock-plus/" }

+ ]

+ },

+ {

+ "id": "abb",

+ "icons": ["abb-icon.png", "abb-icon-2x.png"],

saroyanm 2018/03/19 19:04:07 The small icon is 500px on 500px, as far as I can

ire 2018/03/20 07:25:26 You're right. i just copied the images from the sp

+ "icon_alt": "Adblock Browser logo",

+ "title": "Block ads in a dedicated ad-blocking browser",

+ "platforms": [

+ { "name": "Adblock Browser (Android)", "url": "https://play.google.com/store/apps/details?id=org.adblockplus.browser" },

saroyanm 2018/03/19 19:04:07 We can use redirection links instead: https://adbl

ire 2018/03/20 07:25:26 Will bring this up with Jeen

+ { "name": "Adblock Browser (iOS)", "url": "https://itunes.apple.com/my/app/adblock-browser/id1015653330?mt=8&ign-itsct=1015653330-1015653330&ign-itscg=0176&ign-mpt=uo%3D4" }

+ ]

+ }

+] %}

+<header class="bg-primary section content text-center">

+ <div class="container">

+ <img height="90px"

+ width="90px"

+ src="/img/download-icon.png"

+ srcset="/img/download-icon.svg 2x"

+ alt="{{ "White down arrow" | translate("download-icon", "Alt text") }}">

+ <h1>{{ "Get Adblock Plus products on these devices" | translate("download-heading", "Heading") }}</h1>

+ <p>{{ "Supported platforms" | translate("download-subheading", "Subheading") }}</p>

+ </div>

+</header>

+<div class="item-group container text-center content">

+ <div class="row">

+ {% for device in supported_devices %}

+ <div class="column one-third">

+ <img

+ height="90px"

+ width="90px"

+ src="/img/{{ device.icons[0] }}"

+ srcset="/img/{{ device.icons[1] }} 2x"

+ alt="{{ device.icon_alt | translate(device.id + "-icon-alt", "Alt text") }}">

+ <h2>{{ device.title | translate(device.id + "-title", "Heading") }}</h2>

+ <div>

+ {% if device.description %}

+ <p>{{ device.description | safe | translate(device.id + "-description", "Paragraph") }}</p>

+ {% endif %}

+ <ul class="horizontal-list">

+ {% for platform in device.platforms %}

+ <li>

+ {% set platform_identifier = device.id + "-product-name-" + loop.index | string %}

+ <a href="{{ platform.url }}">{{ platform.name | translate(platform_identifier, "Product name") }}</a>{{ ", " if loop.index != loop.length }}

saroyanm 2018/03/19 19:04:06 Detail: There are some Browser names that are loca

ire 2018/03/20 07:25:25 I will bring this up with Tamara

ire 2018/03/20 14:40:58 According to Tamara we should not be using the fix

saroyanm 2018/03/23 18:33:39 Acknowledged.

+ </li>

+ {% endfor %}

+ </ul>

+ </div>

+ {% endfor %}

+ </div>

+</div>

« no previous file with comments | « includes/features.html ('k') | static/css/index.css » ('j') | no next file with comments »