Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: test/compiled/String.cpp

Issue 29722755: Issue 6378 - [emscripten] Make DependentString constexpr
Patch Set: Made _str constexpr. Created March 15, 2018, 4:09 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« compiled/String.h ('K') | « compiled/String.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 #include <string> 18 #include <string>
19 #include <gtest/gtest.h> 19 #include <gtest/gtest.h>
20 #include "compiled/String.h" 20 #include "compiled/String.h"
21 21
22 ABP_NS_USING 22 ABP_NS_USING
23 23
24 TEST(TestString, checkConstexprCorrectness)
Eric 2018/03/15 17:05:01 Since all the static_assert statements don't gener
René Jeschke 2018/03/15 17:41:23 Is it really worth it to clutter the test code wit
Eric 2018/03/15 18:33:54 I should preface these comments by saying that I a
René Jeschke 2018/03/15 19:02:34 Okay, fine with me. I separated the tests. The onl
25 {
26 static constexpr DependentString s(u"Hello world!");
27 static constexpr DependentString s2;
28 static constexpr DependentString s3 = u"Hello again!"_str;
29
30 static_assert(s.length() == 12, "Length should be 12");
31 static_assert(s3.length() == 12, "Length should be 12");
32
33 static_assert(!s.empty(), "String should not be empty");
34 static_assert(!s.is_writable(), "String should not be writable");
35 static_assert(!s.is_deleted(), "String should not be deleted");
36
37 static_assert(s.data()[0] == 'H', "First character should be 'H'");
38 static_assert(s[1] == 'e', "Second character should be 'e'");
39
40 static_assert(s2.is_invalid(), "String should be invalid");
41 }
42
24 TEST(TestString, constructInvalidDependentString) 43 TEST(TestString, constructInvalidDependentString)
25 { 44 {
26 DependentString s; 45 DependentString s;
27 EXPECT_TRUE(s.is_invalid()); 46 EXPECT_TRUE(s.is_invalid());
28 47
29 DependentString s2(s); 48 DependentString s2(s);
30 EXPECT_TRUE(s2.is_invalid()); 49 EXPECT_TRUE(s2.is_invalid());
31 } 50 }
32 51
33 TEST(TestString, constructInvalidOwnedString) 52 TEST(TestString, constructInvalidOwnedString)
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 EXPECT_FALSE(lexical_cast<bool>(ABP_TEXT("some-string"_str))); 187 EXPECT_FALSE(lexical_cast<bool>(ABP_TEXT("some-string"_str)));
169 EXPECT_FALSE(lexical_cast<bool>(ABP_TEXT(""_str))); 188 EXPECT_FALSE(lexical_cast<bool>(ABP_TEXT(""_str)));
170 EXPECT_FALSE(lexical_cast<bool>(DependentString())); 189 EXPECT_FALSE(lexical_cast<bool>(DependentString()));
171 } 190 }
172 191
173 TEST(TestStringLexicalCast, toOwnedString) 192 TEST(TestStringLexicalCast, toOwnedString)
174 { 193 {
175 EXPECT_EQ(ABP_TEXT("some-string"_str), lexical_cast<OwnedString>(ABP_TEXT("som e-string"_str))); 194 EXPECT_EQ(ABP_TEXT("some-string"_str), lexical_cast<OwnedString>(ABP_TEXT("som e-string"_str)));
176 EXPECT_EQ(ABP_TEXT(""_str), lexical_cast<OwnedString>(ABP_TEXT(""_str))); 195 EXPECT_EQ(ABP_TEXT(""_str), lexical_cast<OwnedString>(ABP_TEXT(""_str)));
177 } 196 }
OLDNEW
« compiled/String.h ('K') | « compiled/String.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld