Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: test/compiled/String.cpp

Issue 29722755: Issue 6378 - [emscripten] Make DependentString constexpr
Left Patch Set: More constexprs, test cases. Created March 15, 2018, 5:38 p.m.
Right Patch Set: Added missing '*'. Created March 19, 2018, 1:39 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « compiled/String.h ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 #include <string> 18 #include <string>
19 #include <gtest/gtest.h> 19 #include <gtest/gtest.h>
20 #include "compiled/String.h" 20 #include "compiled/String.h"
21 21
22 ABP_NS_USING 22 ABP_NS_USING
23 23
24 void checkConstexprCorrectness() 24 constexpr void checkConstexprTemplateCtor()
25 { 25 {
26 static constexpr DependentString s(u"Hello world!"); 26 constexpr DependentString s(u"Test string");
27 static constexpr DependentString s2; 27 }
28 static constexpr DependentString s3(u"Hello again!", 12); 28
29 static constexpr DependentString s4 = u"Hello again!"_str; 29 constexpr void checkConstexprInvalidCtor()
30 30 {
31 static_assert(s.length() == 12, "Length should be 12"); 31 constexpr DependentString s;
32 static_assert(s3.equals(s4), "Strings should be equal"); 32 static_assert(s.is_invalid(), "String should be invalid");
33 static_assert(s4 == s3, "Strings should be equal"); 33 }
34
35 constexpr void checkConstexprCtor()
36 {
37 constexpr DependentString s(u"Test string", 11);
38 }
39
40 constexpr void checkConstexprFuncsAndOps()
41 {
42 constexpr DependentString s = u"Test string"_str;
43 constexpr DependentString s2 = u"Test string"_str;
44 constexpr DependentString s3 = u"Another test string"_str;
45
46 static_assert(s.length() == s2.length(), "Length should be equal");
47 static_assert(s.equals(s2), "Strings should be equal");
48 static_assert(s == s2, "Strings should be equal");
49 static_assert(s != s3, "Strings should not be equal");
34 50
35 static_assert(!s.empty(), "String should not be empty"); 51 static_assert(!s.empty(), "String should not be empty");
36 static_assert(!s.is_writable(), "String should not be writable"); 52 static_assert(!s.is_writable(), "String should not be writable");
37 static_assert(!s.is_deleted(), "String should not be deleted"); 53 static_assert(!s.is_deleted(), "String should not be deleted");
38 54
39 static_assert(s.data()[0] == 'H', "First character should be 'H'"); 55 static_assert(s.data()[0] == 'T', "First character should be 'T'");
40 static_assert(s[1] == 'e', "Second character should be 'e'"); 56 static_assert(s[1] == 'e', "Second character should be 'e'");
41 57
42 static_assert(s2.is_invalid(), "String should be invalid"); 58 static_assert(s.find(u'e') == 1, "'e' should be at pos 1");
Eric 2018/03/15 18:33:54 Does calling empty(), is_writable(), etc. on inval
sergei 2018/03/16 13:43:26 Could you please create an issue for that? Since n
59 static_assert(s.find(s2) == 0, "String should be found at pos 0");
60 static_assert(s.rfind(u'e') == 1, "'e' should be at pos 1");
43 } 61 }
44 62
45 TEST(TestString, constructInvalidDependentString) 63 TEST(TestString, constructInvalidDependentString)
46 { 64 {
47 DependentString s; 65 DependentString s;
48 EXPECT_TRUE(s.is_invalid()); 66 EXPECT_TRUE(s.is_invalid());
49 67
50 DependentString s2(s); 68 DependentString s2(s);
51 EXPECT_TRUE(s2.is_invalid()); 69 EXPECT_TRUE(s2.is_invalid());
52 } 70 }
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 EXPECT_FALSE(lexical_cast<bool>(ABP_TEXT("some-string"_str))); 207 EXPECT_FALSE(lexical_cast<bool>(ABP_TEXT("some-string"_str)));
190 EXPECT_FALSE(lexical_cast<bool>(ABP_TEXT(""_str))); 208 EXPECT_FALSE(lexical_cast<bool>(ABP_TEXT(""_str)));
191 EXPECT_FALSE(lexical_cast<bool>(DependentString())); 209 EXPECT_FALSE(lexical_cast<bool>(DependentString()));
192 } 210 }
193 211
194 TEST(TestStringLexicalCast, toOwnedString) 212 TEST(TestStringLexicalCast, toOwnedString)
195 { 213 {
196 EXPECT_EQ(ABP_TEXT("some-string"_str), lexical_cast<OwnedString>(ABP_TEXT("som e-string"_str))); 214 EXPECT_EQ(ABP_TEXT("some-string"_str), lexical_cast<OwnedString>(ABP_TEXT("som e-string"_str)));
197 EXPECT_EQ(ABP_TEXT(""_str), lexical_cast<OwnedString>(ABP_TEXT(""_str))); 215 EXPECT_EQ(ABP_TEXT(""_str), lexical_cast<OwnedString>(ABP_TEXT(""_str)));
198 } 216 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld