Issue 6378 - [emscripten] Make DependentString constexpr

test/compiled/String.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <string>
 #include <gtest/gtest.h>
 #include "compiled/String.h"
 
 ABP_NS_USING
 
-void checkConstexprCorrectness()
-{
-  static constexpr DependentString s(u"Hello world!");
-  static constexpr DependentString s2;
-  static constexpr DependentString s3(u"Hello again!", 12);
-  static constexpr DependentString s4 = u"Hello again!"_str;
-
-  static_assert(s.length() == 12, "Length should be 12");
-  static_assert(s3.equals(s4), "Strings should be equal");
-  static_assert(s4 == s3, "Strings should be equal");
+constexpr void checkConstexprTemplateCtor()
+{
+  constexpr DependentString s(u"Test string");
+}
+
+constexpr void checkConstexprInvalidCtor()
+{
+  constexpr DependentString s;
+  static_assert(s.is_invalid(), "String should be invalid");
+}
+
+constexpr void checkConstexprCtor()
+{
+  constexpr DependentString s(u"Test string", 11);
+}
+
+constexpr void checkConstexprFuncsAndOps()
+{
+  constexpr DependentString s = u"Test string"_str;
+  constexpr DependentString s2 = u"Test string"_str;
+  constexpr DependentString s3 = u"Another test string"_str;
+
+  static_assert(s.length() == s2.length(), "Length should be equal");
+  static_assert(s.equals(s2), "Strings should be equal");
+  static_assert(s == s2, "Strings should be equal");
+  static_assert(s != s3, "Strings should not be equal");
 
   static_assert(!s.empty(), "String should not be empty");
   static_assert(!s.is_writable(), "String should not be writable");
   static_assert(!s.is_deleted(), "String should not be deleted");
 
-  static_assert(s.data()[0] == 'H', "First character should be 'H'");
+  static_assert(s.data()[0] == 'T', "First character should be 'T'");
   static_assert(s[1] == 'e', "Second character should be 'e'");
 
-  static_assert(s2.is_invalid(), "String should be invalid");

[Eric, 2018/03/15 18:33:54]

Does calling empty(), is_writable(), etc. on invalid strings return a
placeholder result or do they throw?
Do we care about this difference in behavior?

[sergei, 2018/03/16 13:43:26]

Could you please create an issue for that? Since now we have native tests one
can cover such cases in tests. Additionally it would be better to add more
checks of arguments, e.g. DependentString(nullptr, 10) looks like an invalid
string or there is perhaps even something wrong.

Basically nothing is supposed to throw here when it runs in JS, however if
someone wants, it's possible to achieve it. For invalid string `empty` returns
true and `is_writable` returns false.

+  static_assert(s.find(u'e') == 1, "'e' should be at pos 1");
+  static_assert(s.find(s2) == 0, "String should be found at pos 0");
+  static_assert(s.rfind(u'e') == 1, "'e' should be at pos 1");
 }
 
 TEST(TestString, constructInvalidDependentString)
 {
   DependentString s;
   EXPECT_TRUE(s.is_invalid());
 
   DependentString s2(s);
   EXPECT_TRUE(s2.is_invalid());
 }
@@ skipping 136 matching lines @@
   EXPECT_FALSE(lexical_cast<bool>(ABP_TEXT("some-string"_str)));
   EXPECT_FALSE(lexical_cast<bool>(ABP_TEXT(""_str)));
   EXPECT_FALSE(lexical_cast<bool>(DependentString()));
 }
 
 TEST(TestStringLexicalCast, toOwnedString)
 {
   EXPECT_EQ(ABP_TEXT("some-string"_str), lexical_cast<OwnedString>(ABP_TEXT("some-string"_str)));
   EXPECT_EQ(ABP_TEXT(""_str), lexical_cast<OwnedString>(ABP_TEXT(""_str)));
 }