Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: test/compiled/String.cpp

Issue 29722755: Issue 6378 - [emscripten] Make DependentString constexpr
Left Patch Set: Even more constexpr and tests. Created March 19, 2018, 1:26 p.m.
Right Patch Set: Added missing '*'. Created March 19, 2018, 1:39 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « compiled/String.h ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 13 *
sergei 2018/03/19 13:33:04 Could you please revert the change.
René Jeschke 2018/03/19 13:39:55 Done.
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 #include <string> 18 #include <string>
19 #include <gtest/gtest.h> 19 #include <gtest/gtest.h>
20 #include "compiled/String.h" 20 #include "compiled/String.h"
21 21
22 ABP_NS_USING 22 ABP_NS_USING
23 23
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 EXPECT_FALSE(lexical_cast<bool>(ABP_TEXT("some-string"_str))); 207 EXPECT_FALSE(lexical_cast<bool>(ABP_TEXT("some-string"_str)));
208 EXPECT_FALSE(lexical_cast<bool>(ABP_TEXT(""_str))); 208 EXPECT_FALSE(lexical_cast<bool>(ABP_TEXT(""_str)));
209 EXPECT_FALSE(lexical_cast<bool>(DependentString())); 209 EXPECT_FALSE(lexical_cast<bool>(DependentString()));
210 } 210 }
211 211
212 TEST(TestStringLexicalCast, toOwnedString) 212 TEST(TestStringLexicalCast, toOwnedString)
213 { 213 {
214 EXPECT_EQ(ABP_TEXT("some-string"_str), lexical_cast<OwnedString>(ABP_TEXT("som e-string"_str))); 214 EXPECT_EQ(ABP_TEXT("some-string"_str), lexical_cast<OwnedString>(ABP_TEXT("som e-string"_str)));
215 EXPECT_EQ(ABP_TEXT(""_str), lexical_cast<OwnedString>(ABP_TEXT(""_str))); 215 EXPECT_EQ(ABP_TEXT(""_str), lexical_cast<OwnedString>(ABP_TEXT(""_str)));
216 } 216 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld