#9024 - Introduce class abp::mercurial::extension::hggit

modules/adblockplus/manifests/mercurial/extension/hggit.pp

+# == Class: adblockplus::mercurial::extension::hggit
+#
+# See http://hub.eyeo.com/issues/9024
+# This class should be obsolete when puppet is => 4.1.0 due `install_options`
+# being included for pip provider.
+#
+class adblockplus::mercurial::extension::hggit (
+  $ensure = '0.8.9',
+) {
+
+  ensure_packages([
+    'python-pip',
+    'libffi-dev',
+    'libssl-dev',

[mathias, 2018/03/16 09:03:33]

Couldn't you use a $dependencies list with these items and recycle them as
Package[$dependencies] later on, just to avoid the repetition?

[f.lopez, 2018/03/16 18:11:46]

Acknowledged.

+  ])
+
+  exec {'upgrade setuptools':
+    command => '/usr/bin/pip install --upgrade setuptools',
+    require => Package['python-pip', 'libffi-dev', 'libssl-dev'],
+  }
+
+  exec {'upgrade urllib3':
+    command => '/usr/bin/pip install --upgrade urllib3',
+    require => Package['python-pip', 'libffi-dev', 'libssl-dev'],
+  }
+
+  adblockplus::mercurial::extension {'hggit':
+    package => {
+      ensure => $ensure,
+      name => 'hg-git',
+      provider => 'pip',
+    },
+    require => Exec['upgrade urllib3'],
+  }
+}